Skip to content

[AMD-SMI] Allow amdsmi init to succeed when no NIC hardware is present #3403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marifamd merged 2 commits into from
Mar 2, 2026
Merged

[AMD-SMI] Allow amdsmi init to succeed when no NIC hardware is present #3403

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2e56289
Quick fix for the code that populates all AI NIC devices
ajanicijamd Feb 20, 2026
bbd48e8
When no NIC found resturn success
sputhala-amd Feb 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions projects/amdsmi/src/amd_smi/amd_smi_system.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -494,10 +494,15 @@ amdsmi_status_t AMDSmiSystem::populate_brcm_nic_devices() {
#ifdef BRCM_NIC
uint32_t device_count = 0;
amdsmi_status_t amd_smi_status = no_drm_nic.init();

if (amd_smi_status != AMDSMI_STATUS_SUCCESS) {
// No NIC driver/support present (e.g. CI without NIC hardware) - not fatal
return AMDSMI_STATUS_SUCCESS;
}

rsmi_status_t ret = rsmi_num_nic_monitor_devices(&device_count);
if (ret != RSMI_STATUS_SUCCESS) {
return amd::smi::rsmi_to_amdsmi_status(ret);
// No NIC devices or driver not available - not fatal, continue with empty list
return AMDSMI_STATUS_SUCCESS;
}

for (uint32_t i = 0; i < device_count; i++) {
Expand Down Expand Up @@ -561,9 +566,15 @@ amdsmi_status_t AMDSmiSystem::populate_brcm_switch_devices() {
#ifdef BRCM_NIC
uint32_t device_count = 0;
amdsmi_status_t amd_smi_status = no_drm_switch.init();
if (amd_smi_status != AMDSMI_STATUS_SUCCESS) {
// No switch driver/support present (e.g. CI without NIC hardware) - not fatal
return AMDSMI_STATUS_SUCCESS;
}

rsmi_status_t ret = rsmi_num_switch_monitor_devices(&device_count);
if (ret != RSMI_STATUS_SUCCESS) {
return amd::smi::rsmi_to_amdsmi_status(ret);
// No switch devices or driver not available - not fatal, continue with empty list
return AMDSMI_STATUS_SUCCESS;
}

for (uint32_t i = 0; i < device_count; i++) {
Expand Down
Loading