Conversation
76bdd60 to
19578ce
Compare
93af45a to
a63a005
Compare
8436194 to
ee4b209
Compare
This change undoes the revert: bfe5604 Revert '[SWDEV-544298] AINIC implementation [#2798]' (#3418) 1f7eb27 SWDEV-544298_AINIC_implementation - Handle case where machine has no NIC and we are doing 'amd-smi static' (#3250) 00e9b8d [SWDEV-544298] AINIC implementation (#2798) The reason why it was reverted was that it was that the external CMake project, amdsmi_unified, was doing in-source build. We cannot change that CMakeLists.txt file to make it do out of source dir builds. This changes fixes that problem by copying the amdsmi_unified project into the build dir, then building it there, ensuring that even if it builds in its source dir, it is still in the parent project's build dir.
|
This re-reverted #2798 that was causing failures on the nightly builds: ROCm/TheRock/actions/runs/22168787472 Originally reported in #3500 |
This change undoes the revert: bfe5604 Revert '[SWDEV-544298] AINIC implementation [#2798]' (#3418) 1f7eb27 SWDEV-544298_AINIC_implementation - Handle case where machine has no NIC and we are doing 'amd-smi static' (#3250) 00e9b8d [SWDEV-544298] AINIC implementation (#2798) The reason why it was reverted was that it was that the external CMake project, amdsmi_unified, was doing in-source build. We cannot change that CMakeLists.txt file to make it do out of source dir builds. This changes fixes that problem by copying the amdsmi_unified project into the build dir, then building it there, ensuring that even if it builds in its source dir, it is still in the parent project's build dir.
|
FYI - this causes a build failure with gcc14. Attempting to fix forward as this is a local, non-CI compiler suspected false positive: ● The build error is in projects/amdsmi/src/nic/ai-nic/amdsmi_unified/src/smi_sysfs.cpp in SmiSysfsReader::readAll(). GCC 14 with -Werror flags two lines:
Both push an int into a std::vector<std::variant<int, std::string>>. GCC's inliner traces through the variant move constructor and concludes the string length member _M_string_length may be used uninitialized — a known GCC false positive with The error is: Introduced by 410afdc — the AINIC re-land. |
Fixed here: #3633 |
This change undoes the revert: bfe5604 Revert '[SWDEV-544298] AINIC implementation [#2798]' (#3418) 1f7eb27 SWDEV-544298_AINIC_implementation - Handle case where machine has no NIC and we are doing 'amd-smi static' (#3250) 00e9b8d [SWDEV-544298] AINIC implementation (#2798) The reason why it was reverted was that it was that the external CMake project, amdsmi_unified, was doing in-source build. We cannot change that CMakeLists.txt file to make it do out of source dir builds. This changes fixes that problem by copying the amdsmi_unified project into the build dir, then building it there, ensuring that even if it builds in its source dir, it is still in the parent project's build dir.
Motivation
Show AINIC information from amd-smi command line
Technical Details
JIRA ID
SWDEV-544298
Test Plan
Test Result
Pass on device with and without AINIC
Commands:
amd-smi list --nic 0
amd-smi static --nic 0
Submission Checklist