Skip to content

refactor(ndsn) in namelist module files: convert unit allocations from static to dynamic - #1635

Merged
mingchen-NOAA merged 2 commits into
NOAA-EMC:developfrom
EJRainville-NOAA:feature/ndsn-1632
Oct 5, 2026
Merged

mingchen-NOAA merged 2 commits into
NOAA-EMC:developfrom
EJRainville-NOAA:feature/ndsn-1632

Conversation

@EJRainville-NOAA

Copy link
Copy Markdown
Collaborator

Pull Request Summary

Changes all NDSN unit allocations to be dynamic rather than static.

Description

Replaced static NDSN unit allocations with dynamic memory/resource allocation to improve flexibility and optimize resource usage across varying workloads. This PR addresses the comments left by @mingchen-NOAA. This is an enhancement.

Issue(s) addressed

fixes issue #1632

Commit Message

refactor(ndsn) in namelist module files: convert unit allocations from static to dynamic

Check list

Testing

  • How were these changes tested?

These changes were tested with the regression tests using both the intel and GNU compilers on Ursa.

  • Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)

Yes, these changes are covered by the regression tests.

  • Have the matrix regression tests been run (if yes, please note HPC and compiler)?

Yes, the matrix regression tests have been run on Ursa using both the intel and gnu compilers.

  • Please indicate the expected changes in the regression test output, (Note the list of known non-identical tests.)

There are no expected changes to the regression test output.

Comment thread model/src/w3nmlmultimd.F90 Outdated
@mingchen-NOAA

Copy link
Copy Markdown
Collaborator

Matrix tests passed on Ursa Intel.

**********************************************************************
********************* non-identical cases ****************************
**********************************************************************
mww3_test_03/./work_PR3_UNO_MPI_d2                     (19 files differ)
mww3_test_03/./work_PR3_UQ_MPI_e                     (1 files differ)
mww3_test_03/./work_PR3_UNO_MPI_e                     (1 files differ)
mww3_test_03/./work_PR1_MPI_d2                     (19 files differ)
mww3_test_03/./work_PR2_UQ_MPI_e                     (1 files differ)
mww3_test_03/./work_PR3_UQ_MPI_e_c                     (1 files differ)
mww3_test_03/./work_PR2_UNO_MPI_d2                     (15 files differ)
mww3_test_03/./work_PR2_UQ_MPI_d2                     (16 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2_c                     (16 files differ)
mww3_test_03/./work_PR2_UNO_MPI_e                     (1 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2                     (16 files differ)
mww3_test_03/./work_PR1_MPI_e                     (1 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2_c                     (16 files differ)
mww3_test_03/./work_PR3_UNO_MPI_e_c                     (1 files differ)
mww3_test_09/./work_MPI_ASCII                     (0 files differ)
ww3_tp2.10/./work_MPI_OMPH                     (7 files differ)
ww3_tp2.6/./work_ST4_ASCII                     (0 files differ)
ww3_ufs1.3/./work_a                     (3 files differ)

matrixCompFull.txt
matrixCompSummary.txt
matrixDiff.txt

@mingchen-NOAA

Copy link
Copy Markdown
Collaborator

Matrix tests passed on Ursa GNU.

**********************************************************************
********************* non-identical cases ****************************
**********************************************************************
mww3_test_03/./work_PR3_UNO_MPI_d2                     (7 files differ)
mww3_test_03/./work_PR1_MPI_d2                     (6 files differ)
mww3_test_03/./work_PR2_UNO_MPI_d2                     (6 files differ)
mww3_test_03/./work_PR2_UQ_MPI_d2                     (15 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2_c                     (15 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2                     (15 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2_c                     (15 files differ)
mww3_test_09/./work_MPI_ASCII                     (0 files differ)
ww3_tp2.10/./work_MPI_OMPH                     (5 files differ)
ww3_tp2.16/./work_MPI_OMPH                     (4 files differ)
ww3_tp2.6/./work_ST4_ASCII                     (0 files differ)
ww3_ufs1.3/./work_a                     (28 files differ)

matrixCompFull.txt
matrixCompSummary.txt
matrixDiff.txt

@mingchen-NOAA
mingchen-NOAA merged commit 03adda9 into NOAA-EMC:develop Oct 5, 2026
22 checks passed
@mingchen-NOAA

Copy link
Copy Markdown
Collaborator

@EJRainville-NOAA This PR has been merged. Thank you very much for the work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants