Repository navigation
refactor(ndsn) in namelist module files: convert unit allocations from static to dynamic - #1635
Merged
mingchen-NOAA merged 2 commits intoOct 5, 2026
Merged
Conversation
…namelist module files
Collaborator
|
Matrix tests passed on Ursa Intel. |
Collaborator
|
Matrix tests passed on Ursa GNU. |
mingchen-NOAA
approved these changes
Oct 5, 2026
Collaborator
|
@EJRainville-NOAA This PR has been merged. Thank you very much for the work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
Changes all NDSN unit allocations to be dynamic rather than static.
Description
Replaced static NDSN unit allocations with dynamic memory/resource allocation to improve flexibility and optimize resource usage across varying workloads. This PR addresses the comments left by @mingchen-NOAA. This is an enhancement.
Issue(s) addressed
fixes issue #1632
Commit Message
refactor(ndsn) in namelist module files: convert unit allocations from static to dynamic
Check list
Testing
These changes were tested with the regression tests using both the intel and GNU compilers on Ursa.
Yes, these changes are covered by the regression tests.
Yes, the matrix regression tests have been run on Ursa using both the intel and gnu compilers.
There are no expected changes to the regression test output.
matrixDiff_intel.txt
matrixCompSummary_intel.txt
matrixCompFull_intel.txt
matrixDiff_gnu.txt
matrixCompSummary_gnu.txt
matrixCompFull_gnu.txt