Skip to content

refactor(ndsn) in namelist module files: convert unit allocations from static to dynamic #1635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mingchen-NOAA merged 2 commits into from
Oct 5, 2026
Merged

refactor(ndsn) in namelist module files: convert unit allocations from static to dynamic #1635

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8fc711f
Changed all explicit NDSN definitions to dynamic allocations for all …
EJRainville-NOAA Sep 29, 2026
1cee5bd
Fixed one additional explicit unit allocation
EJRainville-NOAA Oct 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions model/src/w3nmlbouncmd.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,8 +122,7 @@ SUBROUTINE W3NMLBOUNC (NDSI, INFILE, NML_BOUND, IERR)
#endif

! open namelist log file
NDSN = 3
OPEN (NDSN, file=TRIM(INFILE)//'.log', form='formatted', iostat=IERR)
OPEN (NEWUNIT=NDSN, file=TRIM(INFILE)//'.log', form='formatted', iostat=IERR)
IF (IERR.NE.0) THEN
WRITE (NDSE,'(A)') 'ERROR: open full nml file '//TRIM(INFILE)//'.log failed'
RETURN
Expand Down
3 changes: 1 addition & 2 deletions model/src/w3nmlboundmd.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,8 +116,7 @@ SUBROUTINE W3NMLBOUND (NDSI, INFILE, NML_BOUND, IERR)
!/S CALL STRACE (IENT, 'W3NMLBOUND')

! open namelist log file
NDSN = 3
OPEN (NDSN, file=TRIM(INFILE)//'.log', form='formatted', iostat=IERR)
OPEN (NEWUNIT=NDSN, file=TRIM(INFILE)//'.log', form='formatted', iostat=IERR)
IF (IERR.NE.0) THEN
WRITE (NDSE,'(A)') 'ERROR: open full nml file '//TRIM(INFILE)//'.log failed'
RETURN
Expand Down
3 changes: 1 addition & 2 deletions model/src/w3nmlgridmd.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,8 +401,7 @@ SUBROUTINE W3NMLGRID (NDSI, INFILE, NML_SPECTRUM, NML_RUN, &
#endif

! open namelist log file
NDSN = 3
OPEN (NDSN, file=TRIM(INFILE)//'.log', form='formatted', iostat=IERR)
OPEN (NEWUNIT=NDSN, file=TRIM(INFILE)//'.log', form='formatted', iostat=IERR)
IF (IERR.NE.0) THEN
WRITE (NDSE,'(A)') 'ERROR: open full nml file '//TRIM(INFILE)//'.log failed'
RETURN
Expand Down
6 changes: 2 additions & 4 deletions model/src/w3nmlmultimd.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,8 +314,7 @@ SUBROUTINE W3NMLMULTIDEF (MPICOMM, NDSI, INFILE, NML_DOMAIN, IERR)

! open namelist log file
IF ( NMPLOG .EQ. IMPROC ) THEN
NDSN = 3
OPEN (NDSN, file=TRIM(INFILE)//'.log', form='formatted', iostat=IERR)
OPEN (NEWUNIT=NDSN, file=TRIM(INFILE)//'.log', form='formatted', iostat=IERR)
IF (IERR.NE.0) THEN
WRITE (MDSE,'(A)') 'ERROR: open full nml file '//TRIM(INFILE)//'.log failed'
RETURN
Expand Down Expand Up @@ -479,8 +478,7 @@ SUBROUTINE W3NMLMULTICONF (MPICOMM, NDSI, INFILE, NML_DOMAIN, &

! open namelist log file
IF ( NMPLOG .EQ. IMPROC ) THEN
NDSN = 3
OPEN (NDSN, file=TRIM(INFILE)//'.log', form='formatted', status='old', iostat=IERR)
OPEN (NEWUNIT=NDSN, file=TRIM(INFILE)//'.log', form='formatted', status='old', iostat=IERR)
IF (IERR.NE.0) THEN
WRITE (MDSE,'(A)') 'ERROR: open full nml file '//TRIM(INFILE)//'.log failed'
RETURN
Expand Down
3 changes: 1 addition & 2 deletions model/src/w3nmlounfmd.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,8 +158,7 @@ SUBROUTINE W3NMLOUNF (NDSI, INFILE, NML_FIELD, NML_FILE, NML_SMC, IERR)
#endif

! open namelist log file
NDSN = 3
OPEN (NDSN, file=TRIM(INFILE)//'.log', form='formatted', iostat=IERR)
OPEN (NEWUNIT=NDSN, file=TRIM(INFILE)//'.log', form='formatted', iostat=IERR)
IF (IERR.NE.0) THEN
WRITE (NDSE,'(A)') 'ERROR: open full nml file '//TRIM(INFILE)//'.log failed'
RETURN
Expand Down
3 changes: 1 addition & 2 deletions model/src/w3nmlounpmd.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,8 +170,7 @@ SUBROUTINE W3NMLOUNP (NDSI, INFILE, NML_POINT, NML_FILE, &
#endif

! open namelist log file
NDSN = 3
OPEN (NDSN, file=TRIM(INFILE)//'.log', form='formatted', iostat=IERR)
OPEN (NEWUNIT=NDSN, file=TRIM(INFILE)//'.log', form='formatted', iostat=IERR)
IF (IERR.NE.0) THEN
WRITE (NDSE,'(A)') 'ERROR: open full nml file '//TRIM(INFILE)//'.log failed'
RETURN
Expand Down
3 changes: 1 addition & 2 deletions model/src/w3nmloutpmd.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,8 +171,7 @@ SUBROUTINE W3NMLOUTP(NDSI, INFILE, NML_POINT, &
#endif

! open namelist log file
NDSN = 3
OPEN (NDSN, file=TRIM(INFILE)//'.log', form='formatted', iostat=IERR)
OPEN (NEWUNIT=NDSN, file=TRIM(INFILE)//'.log', form='formatted', iostat=IERR)
IF (IERR.NE.0) THEN
WRITE (NDSE,'(A)') 'ERROR: open full nml file '//TRIM(INFILE)//'.log failed'
RETURN
Expand Down
3 changes: 1 addition & 2 deletions model/src/w3nmlprncmd.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,8 +161,7 @@ SUBROUTINE W3NMLPRNC (NDSI, INFILE, NML_FORCING, NML_FILE, IERR)
#endif

! open namelist log file
NDSN = 3
OPEN (NDSN, file=TRIM(INFILE)//'.log', form='formatted', iostat=IERR)
OPEN (NEWUNIT=NDSN, file=TRIM(INFILE)//'.log', form='formatted', iostat=IERR)
IF (IERR.NE.0) THEN
WRITE (NDSE,'(A)') 'ERROR: open full nml file '//TRIM(INFILE)//'.log failed'
RETURN
Expand Down
3 changes: 1 addition & 2 deletions model/src/w3nmlshelmd.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,8 +301,7 @@ SUBROUTINE W3NMLSHEL (MPICOMM, NDSI, INFILE, NML_DOMAIN, &

! open namelist log file
IF ( NMPLOG .EQ. IMPROC ) THEN
NDSN = 3
OPEN (NDSN, file=TRIM(INFILE)//'.log', form='formatted', iostat=IERR)
OPEN (NEWUNIT=NDSN, file=TRIM(INFILE)//'.log', form='formatted', iostat=IERR)
IF (IERR.NE.0) THEN
WRITE (MDSE,'(A)') 'ERROR: open full nml file '//TRIM(INFILE)//'.log failed'
RETURN
Expand Down
3 changes: 1 addition & 2 deletions model/src/w3nmltrncmd.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,8 +129,7 @@ SUBROUTINE W3NMLTRNC (NDSI, INFILE, NML_TRACK, NML_FILE, IERR)
#endif

! open namelist log file
NDSN = 3
OPEN (NDSN, file=TRIM(INFILE)//'.log', form='formatted', iostat=IERR)
OPEN (NEWUNIT=NDSN, file=TRIM(INFILE)//'.log', form='formatted', iostat=IERR)
IF (IERR.NE.0) THEN
WRITE (NDSE,'(A)') 'ERROR: open full nml file '//TRIM(INFILE)//'.log failed'
RETURN
Expand Down
3 changes: 1 addition & 2 deletions model/src/w3nmluprstrmd.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,8 +130,7 @@ SUBROUTINE W3NMLUPRSTR (NDSI, INFILE, NML_RESTART, NML_UPDATE, IERR)
#endif

! open namelist log file
NDSN = 3
OPEN (NDSN, file=TRIM(INFILE)//'.log', form='formatted', iostat=IERR)
OPEN (NEWUNIT=NDSN, file=TRIM(INFILE)//'.log', form='formatted', iostat=IERR)
IF (IERR.NE.0) THEN
WRITE (NDSE,'(A)') 'ERROR: open full nml file '//TRIM(INFILE)//'.log failed'
RETURN
Expand Down
Loading