feat(common): default serviceDiscovery to internal view + tls-skip-verify - #1747
Merged
Conversation
…rify Make the platform-standard SD defaults the built-in defaults of serviceDiscovery.env so environments do not have to set them per-env: - SD_PREFER_VIEW default external -> internal (in-cluster consumers prefer the internal K8s DNS view) - SD_TLS_SKIP_VERIFY default false -> true Only affects the fallback when global.serviceDiscovery does not set the field; environments that set it explicitly (e.g. benedita) are unchanged. No merged consumer of serviceDiscovery.env yet, so no render regression.
📝 WalkthroughWalkthroughThe service-discovery environment helper now defaults ChangesService discovery defaults
Possibly related PRs
✨ Finishing Touches✨ Simplify code
Comment |
guimoreirar
added a commit
that referenced
this pull request
Jul 24, 2026
…onfigmap)
Replace the flat SD_* passthrough with lerian-common.serviceDiscovery.env:
- enable per-app via ledger/crm.serviceDiscovery.enabled (SD_ENABLED emitted
from the param); no SD_* in configmap (stays {} — clean).
- env-wide server config derived from global.serviceDiscovery; internal DNS
and external https:// endpoints derived from the chart service + ingress.
- INERT when disabled or global.serviceDiscovery unset → backward-compatible
(benedita keeps driving SD via extraEnvVars until it migrates).
Depends on #1747 for the internal/tls-skip-verify platform defaults.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@charts/lerian-common/templates/_service_discovery.tpl`:
- Line 56: Update the SD_TLS_SKIP_VERIFY rendering in the service-discovery
template to preserve an explicitly configured false value. Replace the
default-based expression with a presence-aware lookup using the existing
service-discovery TLS configuration, while retaining true only when the setting
is absent.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 5cee1c42-987a-499c-b0aa-98bb77a92cab
📒 Files selected for processing (1)
charts/lerian-common/templates/_service_discovery.tpl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the platform-standard SD defaults the built-in defaults of
lerian-common.serviceDiscovery.env, so environments do not have to set them in everyglobal.serviceDiscovery:SD_PREFER_VIEW:external→internal(in-cluster consumers prefer the internal K8s DNS view)SD_TLS_SKIP_VERIFY:false→trueSD_TLS(false),SD_INTERNAL_SCHEME(http),SD_EXTERNAL_PORT(443) unchanged.Only affects the fallback when
global.serviceDiscovery.<field>is unset. Environments that set them explicitly (benedita dev-st sets both) are unchanged.serviceDiscovery.envhas no merged consumer yet (midaz is the first), so no render regression.Verified: with only
global.serviceDiscovery.addressset, the block now rendersSD_PREFER_VIEW: "internal"+SD_TLS_SKIP_VERIFY: "true". strict: 0 violations.