Skip to content

feat(common): default serviceDiscovery to internal view + tls-skip-verify #1747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
guimoreirar merged 1 commit into from
Jul 24, 2026
Merged

feat(common): default serviceDiscovery to internal view + tls-skip-verify #1747

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions charts/lerian-common/templates/_service_discovery.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,9 +53,9 @@ global.serviceDiscovery (all optional except address when enabled):
would produce a duplicate key. This helper only adds the derived siblings. */ -}}
SD_ADDRESS: {{ $sd.address | quote }}
SD_TLS: {{ $sd.tls | default false | quote }}
SD_TLS_SKIP_VERIFY: {{ $sd.tlsSkipVerify | default false | quote }}
SD_TLS_SKIP_VERIFY: {{ $sd.tlsSkipVerify | default true | quote }}
Comment thread
guimoreirar marked this conversation as resolved.
SD_WORKLOAD: {{ $sd.workload | default "" | quote }}
SD_PREFER_VIEW: {{ $sd.preferView | default "external" | quote }}
SD_PREFER_VIEW: {{ $sd.preferView | default "internal" | quote }}
SD_INTERNAL_ADDRESS: {{ include "lerian-common.internalHost" (dict "name" .name "namespace" .namespace) | quote }}
SD_INTERNAL_PORT: {{ .port | quote }}
SD_INTERNAL_SCHEME: {{ $sd.internalScheme | default "http" | quote }}
Expand Down
Loading