fix(common): default SD_TLS_SKIP_VERIFY to false

[guimoreirar]

What

Changes the serviceDiscovery helper default for SD_TLS_SKIP_VERIFY from true to false in charts/lerian-common/templates/_service_discovery.tpl, and bumps lerian-common-helm to 1.2.1.

Why

With | default true, any consumer that enables service-discovery TLS without explicitly overriding tlsSkipVerify gets SD_TLS_SKIP_VERIFY=true, silently disabling certificate verification (MITM risk). Worse, sprig's default treats an explicit false as empty, so even a consumer that sets tlsSkipVerify: false still rendered true.

Now verification is on by default; operators who intentionally skip it must set tlsSkipVerify: true explicitly.

Context

Split out of #1741 (midaz productization) per the repo policy of scoping lerian-common changes to their own PR. The midaz PR sets serviceDiscovery.tlsSkipVerify: false in its values; that becomes effective once this merges and #1741 rebases. midaz is currently the only consumer of serviceDiscovery.env (none on main), so the blast radius is limited.

Backward compatibility

Consumers already setting tlsSkipVerify: true are unaffected. Only the implicit default changes.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 5da34535-70bb-4279-9505-ebe65dafd69b

📥 Commits

Reviewing files that changed from the base of the PR and between ccbdd3e and bbef066.

📒 Files selected for processing (1)

• charts/lerian-common/templates/_service_discovery.tpl

---

📝 Walkthrough

Walkthrough

The shared Helm service-discovery template now defaults SD_TLS_SKIP_VERIFY to false when global.serviceDiscovery.tlsSkipVerify is unset.

Changes

Service discovery default

Layer / File(s)	Summary
Service discovery helper default charts/lerian-common/templates/_service_discovery.tpl	The emitted SD_TLS_SKIP_VERIFY value now defaults to false when the global TLS setting is unset.

Possibly related PRs

• LerianStudio/helm#1746: Modifies the same service-discovery template and TLS verification default.
• LerianStudio/helm#1747: Modifies the same unset SD_TLS_SKIP_VERIFY default.

✨ Finishing Touches

✨ Simplify code

• Create PR with simplified code
• Commit simplified code in branch fix/lerian-common-sd-tls-skip-verify

---

_{Comment @coderabbitai help to get the list of available commands.}