fix(common): configmap passthrough in serviceDiscovery/streaming env helpers + streaming knobs - #1772
Merged
guimoreirar merged 1 commit intoJul 30, 2026
Conversation
…ing streaming knobs serviceDiscovery.env and streaming.env now accept an optional configmap param and prefer the legacy flat configmap.SD_*/configmap.STREAMING_* value over the global/derived value, mirroring multiTenant.env. This honors the flat configmap backward-compat contract for operators not yet on the derivation model. streaming.env also emits the producer knobs the apps read but the helper previously omitted (STREAMING_SASL_ALLOW_PLAINTEXT, STREAMING_COMPRESSION, STREAMING_REQUIRED_ACKS, STREAMING_BATCH_LINGER_MS, STREAMING_IMPORTANT_EMIT_TIMEOUT_MS), each resolving configmap > global > default, so consumers can drop their inline duplicates. No-configmap callers (midaz #1741, reporter) render byte-identical except the newly-added streaming knobs at their defaults.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe shared Helm helpers now accept optional legacy ConfigMap inputs. Service-discovery values use ChangesShared template configuration overrides
Possibly related PRs
✨ Finishing Touches✨ Simplify code
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
guimoreirar
deleted the
fix/lerian-common-sd-streaming-configmap-passthrough
branch
July 30, 2026 23:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds an optional
configmapparam tolerian-common.serviceDiscovery.envandlerian-common.streaming.envso consumers can honor legacy flatconfigmap.SD_*/configmap.STREAMING_*server keys (each resolvesconfigmap.<KEY>→global.streaming/serviceDiscovery.<field>→ default), mirroring whatmultiTenant.envalready does. Also adds the streaming knobs the apps read:STREAMING_COMPRESSION(lz4),STREAMING_REQUIRED_ACKS(all),STREAMING_BATCH_LINGER_MS(5),STREAMING_IMPORTANT_EMIT_TIMEOUT_MS(5000),STREAMING_SASL_ALLOW_PLAINTEXT(false).Why
A human review of the midaz productization (#1741) found these two helpers read only
global.*and drop the component's legacyconfigmap.*server config — breaking the documented backward-compat contract for on-prem/client values that use theconfigmapblock (multiTenant.envalready handles it). This restores parity and lets midaz + reporter drop their inline streaming-knob duplicates in follow-up PRs.Backward-compatibility (critical)
The
configmapparam is optional (defaults to empty dict). Current callers that don't pass it render byte-identical — the ONLY new output for a no-configmap caller is the 5 streaming knobs at their defaults (the intended parity gap-closer). Proven by rendering midaz with the updated lib: SD block unchanged, streaming block gains only the 5 defaulted knobs; and passingconfigmap.SD_ADDRESS/STREAMING_COMPRESSIONcorrectly wins over global.Scope
charts/lerian-commononly (1-chart-per-PR). No manual version bump (release pipeline auto-bumps). SD timeout/tuning keys (SD_ALLOW_STALEetc.) are emitted by the separateserviceDiscovery.envFlathelper, not this derivation helper, so they are intentionally not added here (the reviewer confirmed their absence is behavior-neutral: empty → unset → same default).Follow-ups (separate PRs)
midaz (#1741) and reporter pass
configmapto their SD/streaming calls + bump the lerian-common pin, and drop their inline streaming-knob emissions.