Skip to content

[Swagger Linter Migration] DeleteInOperationName -> use-delete-for-delete - #5673

Open
Yuchao Yan (msyyc) wants to merge 12 commits into
mainfrom
promote-lintdiff-delete-in-operation-name
Open

Yuchao Yan (msyyc) wants to merge 12 commits into
mainfrom
promote-lintdiff-delete-in-operation-name

Conversation

@msyyc

@msyyc Yuchao Yan (msyyc) commented Oct 12, 2026 •

Copy link
Copy Markdown
Member

Original Swagger linter

Checks:

  • Inspect DELETE operations selected from paths and x-ms-paths.
  • Read operationId, ignoring absent, empty or non-string values.
  • Ignore IDs without an underscore.
  • Accept the case-sensitive Delete prefix before the underscore or after a word-character group prefix.
  • Report a warning on the offending operationId when neither accepted form matches.

How the Swagger linter works

The Spectral function checks selected DELETE operation objects and applies serialized-ID regular expressions. It does not inspect SDK metadata or require ARM provider metadata. Its underscore/group-prefix exemptions can accept a Delete-prefixed group with a non-delete method, or ignore a standalone invalid method ID. Those serialization-dependent exemptions are intentionally not copied. Native endpoint selection also avoids warnings on declarations used only for client customization. The source migration evidence documents emitted-name overrides, historical version selection, one-sided projects and compilation failures rather than treating equal totals as proof of equivalence.

Source TypeSpec lintdiff rule

  • Validator ID: DeleteInOperationName; canonical slug: delete-in-operation-name.
  • Local rule: tsp-lintdiff-local-linter/delete-in-operation-name.
  • Original lintdiff source rule.
  • Canonical source repository: Azure/typespec-azure; source branch: feature/lintdiff-delete-in-operation-name.
  • Source draft PR: [WIP][Swagger Linter Development] DeleteInOperationName #5670.
  • Immutable source commit: a0b5e8d9a9edee978219c2490c72eac7cc79845b; development GitHub review clean after two Balanced rounds on this final pushed commit.
  • Source worktree: C:\dev\worktrees\lintdiff-delete-in-operation-name; clean, no uncommitted source changes.

The source was assumed done for this promotion run and was not modified. It checks authored names on concrete HTTP service endpoints, DELETE only, with a case-insensitive delete prefix and warning targets on the original operation. Initial source commit 8af7a71258c41b8ca10950023c62cc4633bb24fc is historical; the reviewed source above additionally fixes the harness's stale coverage-kind assertion without changing production behavior.

Destination analysis

The agent selected @azure-tools/typespec-client-generator-core because the approved naming-family promotion contract governs common SDK method names. Existing use-create-for-put and supported getLibraryName(..., AllScopes) establish that ownership and implementation pattern. The new public name is use-delete-for-delete.

Both applicability and compiler/HTTP-only authored-name semantics make Azure Core a plausible authored-domain alternative. Core's use-standard-names already checks authored DELETE names in data-plane rulesets, but not the common SDK override domain. An SDK resolver must not introduce TCGC dependencies into Core or ARM. ARM fixture origin alone does not establish ARM-only semantics; this rule requires neither provider metadata nor ARM helpers in production. Existing TCGC get-operation-name is GET-specific and is not equivalent DELETE coverage.

How the promoted TypeSpec linter works

The root listener uses getAllHttpServices and checks concrete service operations with verb delete. A TCGC context created with { mutateNamespace: false } resolves the common SDK name using getLibraryName(context, operation, AllScopes). This honors unscoped client names, exact-name normalization and supported friendly-name fallback, independently of positive language-specific overrides and explicit OpenAPI operation IDs. No emitter or API-version projection is selected, and historical renamed names are not reconstructed.

The prefix remains case-insensitive, severity remains warning and each finding targets the original operation, including when an override supplies the displayed SDK name. Group names do not mask an invalid method name. The authorized adaptation changes only the authored-name domain to common SDK names; source selection, DELETE condition, prefix policy and diagnostic targets remain intact. There is no hand-rolled resolver, serialized-reference inference, namespace mutation or emitter coupling.

The client-sdk ruleset registers the new rule with plain false; ARM/data-plane rulesets and C# default rules are unchanged. Separate Chronus entries classify destination availability as feature and disabled-only ruleset registration as internal.

Fixture-to-native test mapping

Original lintdiff fixture Native vitest case Coverage note
compliant-with-template it("reports a customized standard ARM delete endpoint") Actual source fixture contains a compliant delete and a violating remove despite its directory name. Replace legacy custom action/suppression with supported ArmResourceDeleteSync aliases; preserve prefix contrasts.
compliant-with-template it("accepts a standard ARM delete endpoint") Actual source fixture contains a compliant delete and a violating remove despite its directory name. Replace legacy custom action/suppression with supported ArmResourceDeleteSync aliases; preserve prefix contrasts.
remove-endpoint it("reports an invalid HTTP SDK name") Concrete remove endpoint warns; reduced generic HTTP operation preserves the method-name predicate.
delete-endpoint it("accepts a valid HTTP SDK name") Concrete delete-prefixed endpoint complies.
common-name-fixes-id it("accepts a common SDK name override") Authorized domain adaptation: unscoped valid SDK name fixes authored remove; source authored rule intentionally still warns.
common-name-invalidates-id it("reports an invalid unscoped client name on the authored operation") Authorized domain adaptation: invalid common override warns despite authored deleteWidget; target remains original declaration.
ungrouped-remove it("reports an invalid HTTP SDK name") Same minimal standalone endpoint proves no underscore/group exemption; shared native case is deliberate.
delete-group-remove it("does not let a Delete-prefixed group mask an invalid method name") Group prefix cannot hide invalid common method name.
N/A (documentation regression) it("reports the published incorrect template alias") Compile actual Markdown setup and incorrect ArmResourceDeleteSync alias; require one warning on remove.
N/A (documentation regression) it("accepts the published correct template alias") Compile actual Markdown correct alias with no target-rule diagnostics.
N/A (documentation regression) it("accepts the published template client name override") Compile actual Markdown common-name override with no target-rule diagnostics.
N/A (documentation regression) it("accepts the published template suppression") Compile actual Markdown suppression with the rule explicitly enabled through the compiler linter; require no diagnostics.

Additional native cases prove SDK override directions, language-specific and mixed names, exact names, friendly fallback, explicit-ID independence, original targets, multiple endpoint findings, non-DELETE controls, case-insensitive prefixes, source endpoint-selection regression, and a common client name on a supported standard ARM deletion alias. Framework-only import exclusion, ordinary inheritance/traversal, uninstantiated-template and suppression tests were not mechanically copied. No validator snapshots, fixtures or corpus payloads are included.

Migration evidence

See source migration.md for focused tests, representative services, full-corpus counts, one-sided project explanations, retained compile failures and uncertainty. Those counts describe the immutable authored-name source, not fresh SDK-domain equivalence or predicted impact. Promotion did not rerun the lintdiff harness or corpus.

Validation

  • Required target dependency-closure build, TCGC package build/lint: exit 0.
  • Final emitter-free native rule suite: 28/28, including four tests that read and compile the actual published Markdown examples; target rule also passes all 28 cases in the full package run.
  • Required TCGC docs regeneration and explicit formatting/check of all four native/generated Markdown paths with NUL ignore override: exit 0; generated ignored rule page remains unstaged.
  • Following template-first skill update Require template-first lint documentation examples #5678 (created before this documentation update), the incorrect/correct, common-name override, and suppression examples use ArmResourceDeleteSync<Widget> instead of raw routes. The standalone shared setup includes all imports/usings. Incorrect remove produces exactly the target warning; correct delete, common-name override, and compiler-enabled suppression produce none. Existing generic HTTP behavior tests remain intact.
  • Rulesets build/lint: exit 0; discovery tests: 5/5.
  • Separate feature/internal Chronus entries verified LF; plain pnpm chronus status: exit 0. Before commit, both change add attempts reported no changed package, so the documented fallback created only these two entries.
  • Full TCGC initial required run: 1660 passed, one 10000ms per-test timeout in arm client with sub clients, two existing skips; 1663 tests in 102 files, natural exit 1.
  • Single coordinator-granted diagnostic, exactly mise exec -- pnpm --filter @azure-tools/typespec-client-generator-core test --maxWorkers=1: 1661 passed, zero failures, same two skips and 1663 tests/102 files, natural exit 0. Same code, assertions, dependencies and 10000ms test/hook limits; no pool change. Timeout recovered with UNPROVEN original cause. The task-wide diagnostic allowance is exhausted (1/1); the scoped concurrency profile may persist for matching later package validation without granting another retry.
  • Latest full package run after template documentation/test changes: 1665 passed, two unchanged existing skips, 1667 total tests in 102 files, exit 0 using the same --maxWorkers=1 profile and unchanged test/hook timeouts. The four added tests account for the population increase.
  • Scoped TypeScript formatting/check and diff hygiene pass. The initial nine-file promotion patch previously passed read-only cached application check with an empty index; subsequent review/doc updates are scoped to the maintained rule documentation and native/rulesets tests.

Validation limitations

Required docs regeneration exits 0 with existing documentation warnings for unnecessary-emitter-option and unused API @param tags on untouched APIs; these unrelated warnings were retained, not repaired. The optional repository-wide wrapper was not warranted for this isolated rule and registration change. No local website/dependency-closure build was run; CI's Website job remains authoritative. The original full-suite timeout remains retained evidence, not an environmental diagnosis.

Promotion sync policy

The source remains immutable during promotion. A verified source-semantic gap blocks this PR and returns evidence to the owning queue, which alone may authorize its bounded source-repair cycle. Refresh native provenance incrementally only after a new clean reviewed source head; do not repair the source or silently alter its semantics in the promoted copy. The expressly approved common SDK naming adaptation is not source repair.

Review cleanup (October 19, 2026)

Renamed the groups to HTTP SDK names and standard ARM operations, preserving their separate SimpleTester and ARM/standalone setup. Removed the extra DELETE behavior file; focused package-level public-entry coverage retains the throwing AutoRest guard, now outside the PUT behavior suite as well. Removed redundant internal entries; feature and rulesets coverage remain.

Published in 50c4b74. Fresh focused validation: 68 tests passed, package production typecheck, root pnpm format, root pnpm lint, and diff hygiene passed. The full test TypeScript project retains pre-existing diagnostics (15 before, 15 after); the exact-head baseline comparison found no new diagnostics, accounting explicitly for moved tests and any removed duplicate fixture. This is not a claim that the full test TypeScript project is error-free or that pending CI has passed. These current file-layout/coverage statements supersede earlier descriptions of the removed test files; historical validation remains historical.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 832854b7-de67-4f1f-8fe1-6a3e9897aeee
@msyyc Yuchao Yan (msyyc) added the int:azure-specs Run integration tests against azure-rest-api-specs label Oct 12, 2026
@microsoft-github-policy-service microsoft-github-policy-service Bot added lib:tcgc Issues for @azure-tools/typespec-client-generator-core library meta:website TypeSpec.io updates linter Issues related to linter rules labels Oct 12, 2026
@github-actions

github-actions Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

All changed packages have been documented.

  • ✅ @azure-tools/typespec-azure-rulesets
  • ✅ @azure-tools/typespec-client-generator-core
Show changes

@azure-tools/typespec-azure-rulesets - internal ✏️

Register the @azure-tools/typespec-client-generator-core/use-delete-for-delete lint rule as disabled in the client-sdk ruleset.

@azure-tools/typespec-client-generator-core - feature ✏️

Add the opt-in use-delete-for-delete lint rule requiring common SDK method names of concrete HTTP DELETE endpoints to start with delete, honoring unscoped client names and the supported friendly-name fallback.

@github-actions

github-actions Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

📦 Package size report

✅ No notable package size changes compared to the base branch.

14 package(s) with no notable change
Package Packed (base → head) Δ Packed Unpacked (base → head) Δ Unpacked
@azure-tools/typespec-client-generator-core 244.86 KB → 244.66 KB -204 B (-0.1%) 1.30 MB → 1.30 MB -529 B (-0.0%)
@azure-tools/typespec-azure-rulesets 5.57 KB → 5.58 KB +13 B (+0.2%) 34.21 KB → 34.40 KB +192 B (+0.5%)
@azure-tools/azure-http-specs 143.52 KB → 143.52 KB — 1.20 MB → 1.20 MB —
@azure-tools/typespec-autorest 87.87 KB → 87.87 KB — 424.17 KB → 424.17 KB —
@azure-tools/typespec-autorest-canonical 7.42 KB → 7.42 KB — 26.00 KB → 26.00 KB —
@azure-tools/typespec-azure-core 136.55 KB → 136.55 KB — 733.30 KB → 733.30 KB —
@azure-tools/typespec-azure-examples 80.15 KB → 80.15 KB — 383.36 KB → 383.36 KB —
@azure-tools/typespec-azure-portal-core 36.26 KB → 36.26 KB — 242.62 KB → 242.62 KB —
@azure-tools/typespec-azure-resource-manager 185.59 KB → 185.59 KB — 1.12 MB → 1.12 MB —
@azure-tools/typespec-go 263.76 KB → 263.76 KB — 1.35 MB → 1.35 MB —
@azure-tools/typespec-java 20.22 MB → 20.22 MB — 22.51 MB → 22.51 MB —
@azure-tools/typespec-metadata 15.91 KB → 15.91 KB — 62.26 KB → 62.26 KB —
@azure-tools/typespec-python 42.54 KB → 42.54 KB — 165.94 KB → 165.94 KB —
@azure-tools/typespec-ts 530.77 KB → 530.77 KB — 2.67 MB → 2.67 MB —

Packed = gzipped .tgz published to npm. Unpacked = total extracted size. 🆕 added, 🗑️ removed. Packages from the core/ submodule are not included.
🔴 grew · 🟢 shrank — only changes of at least 512 B and 0.5% are marked.

@pkg-pr-new

pkg-pr-new Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@azure-tools/typespec-azure-rulesets@5673
npm i https://pkg.pr.new/@azure-tools/typespec-client-generator-core@5673

commit: 5fc361c

@azure-sdk-automation

Copy link
Copy Markdown
Contributor

You can try these changes here

🛝 Playground 🌐 Website

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The disabled ruleset registration lacks a regression assertion, and the suppression guidance is incomplete.

2 open findings
What changed in this PR

Adds an opt-in TCGC linter rule requiring DELETE SDK method names to begin with delete.

Changes:

  • Implements and registers the rule.
  • Adds comprehensive rule tests and documentation.
  • Registers it as disabled by default with Chronus entries.
File Description
.chronus/​changes/​register-use-delete-for-delete.md Records ruleset registration.
.chronus/​changes/​use-delete-for-delete.md Records the new feature.
packages/​typespec-azure-rulesets/​src/​rulesets/​client-sdk.ts Registers the rule as disabled.
packages/​typespec-client-generator-core/​README.md Lists the new rule.
packages/​typespec-client-generator-core/​src/​linter.ts Adds the rule to TCGC’s linter.
packages/​typespec-client-generator-core/​src/​rules/​use-delete-for-delete.md Documents usage and suppression.
packages/​typespec-client-generator-core/​src/​rules/​use-delete-for-delete.ts Implements DELETE endpoint validation.
packages/​typespec-client-generator-core/​test/​rules/​use-delete-for-delete.test.ts Tests naming and override behavior.
website/​src/​content/​docs/​docs/​libraries/​typespec-client-generator-core/​reference/​linter.md Adds the website reference entry.

🧠 Review effort: Balanced


💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread packages/typespec-azure-rulesets/src/rulesets/client-sdk.ts
Comment thread packages/typespec-client-generator-core/src/rules/use-delete-for-delete.md Outdated
Add regression coverage for the disabled SDK naming rule registration and complete the suppression example.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 832854b7-de67-4f1f-8fe1-6a3e9897aeee

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The ARM reviewer guide is missing the required entry for this ARM-applicable migrated rule.

0 open findings

2 resolved since last review
Previously missed (1)

In code that hasn't changed since last review

Low severity Add ARM reviewer guide entry for this rule

packages/​typespec-client-generator-core/​src/​rules/​use-delete-for-delete.md:7

Because this rule explicitly applies to ARM services, it also needs a manual entry in the ARM reviewer guide at website/src/content/docs/docs/howtos/ARM/arm-rules.md. That guide requires a documentation link, LintDiff mapping, and impact for applicable rules (arm-rules.md:54-56) and already lists the analogous TCGC use-create-for-put rule at line 144; docs regeneration does not update this table.

🧠 Review effort: Balanced

Yuchao Yan (msyyc) added a commit that referenced this pull request Oct 13, 2026
## Why

The documentation in #5673 used raw HTTP routes for its
incorrect/correct examples even though supported `ArmResourceDeleteSync`
aliases demonstrate the same diagnostic contrast. The previous policy
required ARM templates only after selecting an ARM audience, allowing a
generic HTTP audience to bypass available templates.

The user requested a template-first requirement in
`/do-linter-development-task-one-by-one` and its related skills, with
this skill-only PR targeting the current branch,
`feature/lintdiff-migration-new`. The promotion documentation will be
updated separately after this PR is created.

## Changes

- Forward the template-first requirement in the queue's promotion
handoff.
- Require supported templates whenever they can demonstrate both
incorrect and correct behavior; inspect customization points before
choosing handwritten routes.
- Preserve audience-appropriate authoring and diagnostic contrast, and
require a documented template limitation for handwritten exceptions.
- Enforce the same requirement in promotion documentation/review and
documentation-example validation.

## Validation

Formatted and checked only the four changed skill Markdown files with
the existing Prettier installation; `git diff --check` passed. Reviewed
the complete four-file diff and existing cross-references. No helper,
package, dependency, submodule, or rule changes; no package builds or
tests are needed.

Copilot-Session: 832854b7-de67-4f1f-8fe1-6a3e9897aeee
Replace raw routes with ArmResourceDeleteSync aliases and validate the actual published examples, including compiler-enabled suppression.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 832854b7-de67-4f1f-8fe1-6a3e9897aeee
@timotheeguerin

Copy link
Copy Markdown
Member

Copilot-generated review feedback.

Could we share the verb-prefix checking flow with #5665 and the existing use-create-for-put rule?

The three rules have almost identical non-mutating TCGC context creation, HTTP-service traversal, common SDK-name resolution through getLibraryName(..., AllScopes), and case-insensitive prefix checking. A small package-private checker could reuse that flow while each rule keeps its own verb/prefix, diagnostic ID, message, docs, and breaking-change guidance.

The common naming resolver already exists, so please reuse it rather than adding another resolver. Keep contexts owned by each rule rather than introducing a shared mutable TCGC context. If the GET naming rule joins this cleanup, first reconcile its operation-listener scope and empty-name behavior instead of silently changing them.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@msyyc

Copy link
Copy Markdown
Member Author

Follow-up to this review feedback.

Extracted the same package-private SDK verb-prefix helper as #5665 and reused it in this DELETE rule and the existing PUT naming rule. Preserved separate non-mutating TCGC contexts, getLibraryName(..., AllScopes), case-insensitive prefix matching and per-rule diagnostics. Documentation-reading tests became ordinary semantic fixtures.

Implemented in 6f0eb98cf. Scoped formatting, type-aware lint, package build and the focused native tests passed. Review threads are intentionally left open.

Yuchao Yan (msyyc) and others added 2 commits October 14, 2026 17:30
Keep native naming and ARM template client-name assertions; remove unused suppression runner plumbing.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
format: { operationName },
});
}
for (const { operation, operationName } of getOperationsWithIncorrectVerbPrefix(

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mark Cowlishaw (@markcowl) what do you think here, should we combine all those rules as a use-correct-verb (or similar)
Yuchao Yan (@msyyc) is there other cases that create and delete?

@msyyc Yuchao Yan (msyyc) Oct 15, 2026 •

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes—PATCH/update is another case. The related rules are:

PR State Naming check
PUT #5457 Merged PUT → create*
PATCH #5665 Open PATCH → update*
DELETE #5673 Open DELETE → delete*

PUT/PATCH/DELETE use the same algorithm: resolve the common SDK method name, then check its prefix case-insensitively. Only the verb, required prefix, and diagnostics differ; the open PRs already share a helper with PUT.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah so feels to me should all just be the same rule

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@iscai-msft

Copy link
Copy Markdown
Member

why is this rule exposed in tcgc instead of typespec-azure-core?

@msyyc

Yuchao Yan (msyyc) commented Oct 16, 2026 •

Copy link
Copy Markdown
Member Author

This rule checks the common SDK method name, including an unscoped @clientName override, through TCGC's getLibraryName(..., AllScopes). For example, an authored DELETE operation named remove with @clientName("deleteWidget") is valid here. Azure Core's naming check uses authored operation names instead. Keeping this SDK-name policy in TCGC avoids either losing those overrides or introducing an Azure Core-to-TCGC dependency. iscai-msft

Yuchao Yan (msyyc) added a commit that referenced this pull request Oct 16, 2026
## Summary

- Treat a lint brief/PR description as the proposal under review, not a
reason to reject clear requests to simplify, revert, or consolidate it.
- Compare existing native mechanisms first; distinguish native
requirements and released compatibility from legacy parity and
complexity introduced by the proposal.
- Delete framework-only suppression/enablement tests without replacement
while retaining concrete rule-owned interactions, authored-node
deduplication, and meaningful regression preconditions.
- Remove bespoke per-rule Markdown parsers instead of moving them into
another suite. Validate published snippets through existing shared
tooling or recorded one-time execution, without claiming continuous
coverage from a one-time receipt.
- Keep actual policy/authorization gates, source immutability, required
validation, and released compatibility intact. Track replies separately
from satisfaction of review concerns.

## Evidence and rationale

This skill-only change follows a retrospective of recorded migration
feedback, not a new live-head review or a change to the underlying rule
PRs.

- [#5591 simplification
direction](#5591 (comment)),
[client-setup
question](#5591 (comment)),
and [model-tree
question](#5591 (comment)):
demonstrating differences from the current design does not independently
establish that its architecture is required.
- [#5551 consolidation
direction](#5551 (comment)):
assess extending the existing native rule and analyze actual
enablement/suppression consequences separately.
- Explicit requests for another maintainer's input, such as
[#5526](#5526 (comment))
and
[#5673](#5673 (comment)),
remain distinct decision dependencies.

The validation skill already discouraged framework-only unit tests, but
evidence-preservation wording could encourage relocating them. Promotion
still explicitly accommodated per-rule Markdown extraction. These
instructions now agree on removing unnecessary infrastructure without
discarding rule-owned behavior or honest published-example evidence.

## Scope

Only five existing skill Markdown files change: discovery,
implementation, validation, development, and promotion. No production
rules, package tests, dependencies, submodules, generated artifacts,
release entries, or CI configuration change. Two custom review/fix
skills stored outside this repository were updated locally in the same
task; they are not included in this PR.

Base: `feature/lintdiff-migration-new`, as explicitly requested.

## Validation

- Existing Prettier 3.9.5: focused Markdown format/check for the changed
files.
- `git diff --check`.
- Checked 78 concrete local Markdown references and heading anchors
across the five changed repository skills; template URL placeholders
were excluded.
- Reviewed the complete task diff and reconciled development/promotion
references with the shared validation guidance.

The root Prettier configuration could not load the unbuilt `core`
TypeSpec plugin. Formatting therefore used the existing Prettier
Markdown parser with the root style options and no custom plugins; no
dependency installation, submodule initialization, or build was
performed for this documentation-only change. Package/source lint and
test suites are not applicable under the skill-only
lightweight-validation policy. Normal CI is left enabled.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Comment thread .chronus/changes/review-delete-sdk-verb-prefix.md Outdated
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Yuchao Yan (msyyc) added a commit that referenced this pull request Oct 19, 2026
## Summary

Update five lint development/promotion skills to prevent the recurring
review feedback in the supplied 58-comment retrospective across 17
migration PRs. Target `feature/lintdiff-migration-new`, the branch
current when this work was requested.

| Review theme | Comments | Prevention |
| --- | ---: | --- |
| Redundant internal change entries | 28 | Inspect and reuse task-owned
unreleased feature/fix coverage before creating entries; preserve
genuinely needed coverage for other packages. |
| Multiple behavior suites for one public rule | 14 | Extend the
canonical suite, found by its imported rule object even when its
historical filename differs from the public name. |
| Repetitive test headings | 13 | Use file-scope cases or meaningful
scenario groups, preserving scoped setup rather than repeating the
rule/filename. |
| Private fixture APIs | 2 | Use supported public imports/decorators;
redesign or remove artificial private-only cases without changing
production scope. |
| Bespoke Markdown parser | 1 | Enforce the existing prohibition without
relocating the parser or losing distinct semantic/example evidence. |

These are five recurring lessons, not 58 independent design judgments:
55 comments explicitly disclose Copilot generation, and three have no
automation disclosure. Original report IDs 37-39 on #5591 and #5654
remain outside the selection.

## Changes

- `typespec-lint-validate`: define canonical suite ownership and
meaningful grouping; clarify genuine public-entry/package tests versus
duplicate rule execution under import guards; require public fixture
APIs.
- `typespec-lint-implement`: centralize unreleased change-entry
reconciliation and include the shared test policies in
implementation/final review.
- `lintdiff-rule-promote`: replace unconditional creation of a test
file/change entry with discovery and reuse; reconcile
acceptance-evidence and review instructions with the shared policies.
- `develop-lintdiff-rule`: reference the shared policies during test
planning and independent review; preserve migration/corpus requirements.
- `create-linter-rule`: apply the same guidance to scaffold cleanup,
existing-rule extensions, public fixtures, and changelog coverage.

## Evidence and boundaries

- [Changelog guidance, report
22](#5502 (comment))
- [Private APIs, report
23](#5502 (comment))
- [One behavior suite per rule, report
36](#5556 (comment))
- [Historical canonical filename, report
48](#5663 (comment))
- [Isolation-suite duplication, report
53](#5665 (comment))
- [Meaningful scenario grouping, report
55](#5673 (comment))
- [Markdown parser removal, report
33](#5551 (comment))

Keep independent utility tests, genuine package/registration evidence,
rule-owned diagnostic regressions, and actual published-example
validation. Keep separate rulesets-package internal coverage when
needed; do not delete all internal entries. Existing production
semantics, audience/enablement, source immutability, parity evidence,
and required validation remain unchanged.

Skills only: no generator, rule implementation/test, package,
dependency, release entry, or CI changes. The scaffolder's redundant
wrapper is explicitly handled by cleanup guidance; changing the
generator is a separate follow-up.

## Validation

- Scoped Prettier write/check on the five changed Markdown files, using
the repository's scalar formatting settings without optional plugins
because the configured TypeSpec plugin has no built output. No
dependencies or submodules were initialized for this documentation
update.
- Relative Markdown file/heading reference checks and full five-file
diff review.
- `git diff --check` and explicit staged-file scope verification.

No package builds, corpus runs, docs regeneration, or repository-wide
formatting/source linting are needed for this Markdown-only change.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

int:azure-specs Run integration tests against azure-rest-api-specs lib:tcgc Issues for @azure-tools/typespec-client-generator-core library linter Issues related to linter rules meta:website TypeSpec.io updates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants