Repository navigation
docs(skills): prevent recurring lint migration review cleanup - #5761
Merged
Yuchao Yan (msyyc) merged 1 commit intoOct 19, 2026
Merged
Yuchao Yan (msyyc) merged 1 commit into
Yuchao Yan (msyyc) merged 1 commit into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Yuchao Yan (msyyc)
marked this pull request as ready for review
October 19, 2026 07:14
Yuchao Yan (msyyc)
requested review from
Mark Cowlishaw (markcowl),
Timothee Guerin (timotheeguerin) and
Jeff Fisher (xirzec)
as code owners
October 19, 2026 07:14
Yuchao Yan (msyyc)
merged commit Oct 19, 2026
0c4049b
into
feature/lintdiff-migration-new
3 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update five lint development/promotion skills to prevent the recurring review feedback in the supplied 58-comment retrospective across 17 migration PRs. Target
feature/lintdiff-migration-new, the branch current when this work was requested.These are five recurring lessons, not 58 independent design judgments: 55 comments explicitly disclose Copilot generation, and three have no automation disclosure. Original report IDs 37-39 on #5591 and #5654 remain outside the selection.
Changes
typespec-lint-validate: define canonical suite ownership and meaningful grouping; clarify genuine public-entry/package tests versus duplicate rule execution under import guards; require public fixture APIs.typespec-lint-implement: centralize unreleased change-entry reconciliation and include the shared test policies in implementation/final review.lintdiff-rule-promote: replace unconditional creation of a test file/change entry with discovery and reuse; reconcile acceptance-evidence and review instructions with the shared policies.develop-lintdiff-rule: reference the shared policies during test planning and independent review; preserve migration/corpus requirements.create-linter-rule: apply the same guidance to scaffold cleanup, existing-rule extensions, public fixtures, and changelog coverage.Evidence and boundaries
Keep independent utility tests, genuine package/registration evidence, rule-owned diagnostic regressions, and actual published-example validation. Keep separate rulesets-package internal coverage when needed; do not delete all internal entries. Existing production semantics, audience/enablement, source immutability, parity evidence, and required validation remain unchanged.
Skills only: no generator, rule implementation/test, package, dependency, release entry, or CI changes. The scaffolder's redundant wrapper is explicitly handled by cleanup guidance; changing the generator is a separate follow-up.
Validation
git diff --checkand explicit staged-file scope verification.No package builds, corpus runs, docs regeneration, or repository-wide formatting/source linting are needed for this Markdown-only change.