[Swagger Linter Migration] PutInOperationName + PatchInOperationName + DeleteInOperationName -> use-correct-verb

.chronus/changes/register-use-delete-for-delete.md

@@ -0,0 +1,7 @@
+---
+changeKind: internal
+packages:
+  - "@azure-tools/typespec-azure-rulesets"
+---
+
+Register the `@azure-tools/typespec-client-generator-core/use-delete-for-delete` lint rule as disabled in the `client-sdk` ruleset.

.chronus/changes/use-delete-for-delete.md

@@ -0,0 +1,7 @@
+---
+changeKind: feature
+packages:
+  - "@azure-tools/typespec-client-generator-core"
+---
+
+Add the opt-in `use-delete-for-delete` lint rule requiring common SDK method names of concrete HTTP DELETE endpoints to start with `delete`, honoring unscoped client names and the supported friendly-name fallback.

packages/typespec-azure-rulesets/src/rulesets/client-sdk.ts

@@ -8,6 +8,7 @@ export default {
     "@azure-tools/typespec-client-generator-core/csharp-model-suffix": true,
     "@azure-tools/typespec-client-generator-core/use-union-hierarchy": true,
     "@azure-tools/typespec-client-generator-core/get-operation-name": false,
+    "@azure-tools/typespec-client-generator-core/use-delete-for-delete": false,
   },
   disable: {
     "@azure-tools/typespec-client-generator-core/use-create-for-put":

packages/typespec-client-generator-core/README.md

@@ -121,6 +121,7 @@ Available ruleSets:
 | Name                                                                                                                                                                                                  | Description                                                                                                                                                         |
 | ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | ------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
 | [`@azure-tools/typespec-client-generator-core/use-create-for-put`](https://azure.github.io/typespec-azure/docs/libraries/typespec-client-generator-core/rules/use-create-for-put)                     | ARM PUT SDK method names should use 'create' as the verb prefix.                                                                                                    |
+| [`@azure-tools/typespec-client-generator-core/use-delete-for-delete`](https://azure.github.io/typespec-azure/docs/libraries/typespec-client-generator-core/rules/use-delete-for-delete)               | DELETE SDK method names should use 'delete' as the verb prefix.                                                                                                     |
 | [`@azure-tools/typespec-client-generator-core/require-client-suffix`](https://azure.github.io/typespec-azure/docs/libraries/typespec-client-generator-core/rules/require-client-suffix)               | Client names should end with 'Client'.                                                                                                                              |
 | [`@azure-tools/typespec-client-generator-core/property-name-conflict`](https://azure.github.io/typespec-azure/docs/libraries/typespec-client-generator-core/rules/property-name-conflict)             | Avoid naming conflicts between a property and a model of the same name.                                                                                             |
 | [`@azure-tools/typespec-client-generator-core/csharp-no-url-suffix`](https://azure.github.io/typespec-azure/docs/libraries/typespec-client-generator-core/rules/csharp-no-url-suffix)                 | Properties ending with 'Url' should use 'Uri' suffix instead to follow .NET naming conventions.                                                                     |

packages/typespec-client-generator-core/src/linter.ts

@@ -6,10 +6,12 @@ import { getOperationNameRule } from "./rules/get-operation-name.rule.js";
 import { propertyNameConflictRule } from "./rules/property-name-conflict.rule.js";
 import { requireClientSuffixRule } from "./rules/require-client-suffix.rule.js";
 import { useCreateForPutRule } from "./rules/use-create-for-put.js";
+import { useDeleteForDeleteRule } from "./rules/use-delete-for-delete.js";
 import { useUnionHierarchyRule } from "./rules/use-union-hierarchy.js";
 
 const rules = [
   useCreateForPutRule,
+  useDeleteForDeleteRule,
   requireClientSuffixRule,
   propertyNameConflictRule,
   csharpNoUrlSuffixRule,

packages/typespec-client-generator-core/src/rules/use-delete-for-delete.md

@@ -0,0 +1,76 @@
+Use an SDK method name beginning with `delete` for HTTP DELETE operations, such as
+`delete` or `deleteWidget`. Consistent names make deletion methods easier to
+discover in generated clients.
+
+The rule checks the common TCGC SDK method name case-insensitively on concrete
+HTTP service endpoints. It applies to ARM and data-plane services without requiring
+`@armProviderNamespace`, and is disabled by default in the `client-sdk` ruleset.
+Client-only declarations that are not service endpoints are not checked.
+
+Name resolution uses TCGC's `getLibraryName` with `AllScopes`, including an
+unscoped `@clientName`, exact names, and the supported `@friendlyName` fallback.
+Overrides applying only to a particular language, such as
+`@clientName("remove", "csharp")`, do not replace the common name.
+
+The source program is checked without selecting an emitter or an API-version
+projection. Historical names supplied through `@renamedFrom` are not reconstructed.
+
+The following examples use generic HTTP authoring: import `@typespec/http`, use
+`TypeSpec.Http`, and place the operation in a `@service` namespace. For ARM
+resources, use the standard
+[resource delete operation templates](https://azure.github.io/typespec-azure/docs/howtos/ARM/resource-operations#resource-delete-operations-delete),
+with a name beginning with `delete`, such as
+`delete is ArmResourceDeleteSync<Widget>;`.
+
+#### ❌ Incorrect
+
+```typespec
+@delete
+@route("/widgets/{id}")
+op remove(@path id: string): void;
+```
+
+#### ✅ Correct
+
+```typespec
+@delete
+@route("/widgets/{id}")
+op deleteWidget(@path id: string): void;
+```
+
+## Impact
+
+- **Area:** SDK
+
+Renaming a method in an already-shipped SDK may introduce a breaking change.
+Review compatibility before changing existing names.
+
+An unscoped `@clientName` can provide the correct SDK name without renaming the
+TypeSpec operation:
+
+```typespec
+@Azure.ClientGenerator.Core.clientName("deleteWidget")
+@delete
+@route("/widgets/{id}")
+op remove(@path id: string): void;
+```
+
+Import `@azure-tools/typespec-client-generator-core` to use `@clientName`.
+
+## Suppression
+
+Suppression is appropriate when preserving an already-shipped SDK method name
+requires an exception approved by the API reviewer. For new methods, fix the
+name instead, either by renaming the operation or using an unscoped `@clientName`.
+Use `#suppress "@azure-tools/typespec-client-generator-core/use-delete-for-delete"`
+on the operation with a justification for the compatibility exception.
+
+## LintDiff Equivalent
+
+This rule enforces the SDK naming intent of
+[`DeleteInOperationName`](https://github.com/Azure/azure-openapi-validator/blob/main/docs/delete-in-operation-name.md).
+It does not reproduce serialized `operationId` underscore or group-prefix
+exemptions. Explicit OpenAPI operation IDs do not change the common SDK method
+name checked by this rule. The lintdiff source checks authored operation names;
+the promoted rule intentionally checks common SDK names, including unscoped
+SDK name overrides.

packages/typespec-client-generator-core/src/rules/use-delete-for-delete.ts

@@ -0,0 +1,46 @@
+import { createRule, fileRef, paramMessage } from "@typespec/compiler";
+import { getAllHttpServices } from "@typespec/http";
+import { createTCGCContext } from "../context.js";
+import { AllScopes } from "../internal-utils.js";
+import { getLibraryName } from "../public-utils.js";
+
+export const useDeleteForDeleteRule = createRule({
+  name: "use-delete-for-delete",
+  description: "DELETE SDK method names should use 'delete' as the verb prefix.",
+  severity: "warning",
+  url: "https://azure.github.io/typespec-azure/docs/libraries/typespec-client-generator-core/rules/use-delete-for-delete",
+  docs: fileRef.fromPackageRoot("src/rules/use-delete-for-delete.md"),
+  messages: {
+    default: paramMessage`DELETE SDK method name '${"operationName"}' should start with 'delete'.`,
+  },
+  create(context) {
+    const tcgcContext = createTCGCContext(
+      context.program,
+      "@azure-tools/typespec-client-generator-core",
+      { mutateNamespace: false },
+    );
+
+    return {
+      root: () => {
+        const [services] = getAllHttpServices(context.program);
+        for (const service of services) {
+          for (const { operation, verb } of service.operations) {
+            if (verb !== "delete") {
+              continue;
+            }
+
+            const operationName = getLibraryName(tcgcContext, operation, AllScopes);
+            if (operationName.toLowerCase().startsWith("delete")) {
+              continue;
+            }
+
+            context.reportDiagnostic({
+              target: operation,
+              format: { operationName },
+            });
+          }
+        }
+      },
+    };
+  },
+});