Problem: CMakeLists.txt does not properly enable drafts#84
Open
BHare1985 wants to merge 1 commit intozeromq:masterfrom
Open
Problem: CMakeLists.txt does not properly enable drafts#84BHare1985 wants to merge 1 commit intozeromq:masterfrom
BHare1985 wants to merge 1 commit intozeromq:masterfrom
Conversation
Solutions: Use the CMake technique employed in zeromq/malamute for detection when to use drafts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solution: Use the CMake technique employed in zeromq/malamute for detection when to use drafts.
This pull request implements a change to allow CLion to properly detect drafts when opening the project as a CMake project. This is achieved by using the same technique employed by the zeromq's 'malamute' project https://github.com/zeromq/malamute/blob/master/CMakeLists.txt#L32-L60
When opening this project in CLion as a CMake project, it fails to detect drafts despite the presence of a .git directory. Since this project relies on drafts and has no sources without them, it's essential that drafts are detected correctly to ensure proper functionality.