Draft
Conversation
Solution: Update zproject
BHare1985
commented
Apr 5, 2024
| "failed to parse FILEMQ_VERSION_${which} from filemq.h" | ||
| ) | ||
| endif() | ||
| set(FILEMQ_${which}_VERSION ${CMAKE_MATCH_1}) |
Author
There was a problem hiding this comment.
I believe the new zproject's approach to this problem is much more elegant so this should be removed
BHare1985
commented
Apr 5, 2024
Comment on lines
-111
to
-120
| ######################################################################## | ||
| # LIBSODIUM dependency | ||
| ######################################################################## | ||
| find_package(libsodium) | ||
| IF (LIBSODIUM_FOUND) | ||
| include_directories(${LIBSODIUM_INCLUDE_DIRS}) | ||
| list(APPEND MORE_LIBRARIES ${LIBSODIUM_LIBRARIES}) | ||
| add_definitions(-DHAVE_LIBSODIUM) | ||
| list(APPEND OPTIONAL_LIBRARIES ${LIBSODIUM_LIBRARIES}) | ||
| ENDIF (LIBSODIUM_FOUND) |
Author
There was a problem hiding this comment.
I really don't think filemq uses CURVE authentication in it's current state so I think dropping the libsodium dependency is reasonable. The current tests do not depend on it, so it is assumed not needed unless someone implements CURVE via libzmq
Only easy logic regenerations were done, a PR will be submitted later to add in the additional logic from zproto
Regenerate .c and .h
Author
|
All src files were regenerated either via zproject or zproto. Zproto has a lot of logic changes that I omitted and will submit as a separate PR at a later date |
Additionally the ruby bindings, but there were no changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solution: Update zproject
The initial commit represents the unedited output obtained by running
gsl project.xmlwithout any pruning. Subsequent commits will gradually prune unnecessary parts and make necessary additions or removals.During my investigation of #84, I discovered that zproject needed to be regenerated. The specific fix for the drafts that fail to compile relates to
.if project.stable(see here). However, currently, CMake is not functioning as expected. Therefore, I will debug why zproject isn't performing its job correctly and why the .git solution works whereas defaulting drafts=on doesn't.This situation serves as a valuable test for zproject, assessing its effectiveness in updating older projects. While it builds successfully on my Debian trixie WSL when using autotools, it encounters issues with cmake.
The objective of this PR is to bring this repository up to date, stress test zproject, gain insights into filemq and its community requirements/desires, and enhance zproject to better meet the needs of both new and established projects within zeromq.
As a first step, I am sharing the output of the updated zproject, which I will document and welcome feedback on each step. I believe this PR is not yet ready for merging and will therefore remain in a draft state.
Here is a todo list based on the output what I think needs done: