Skip to content

Ignore cometGen.tsx files in Knip #938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
manuelblum wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Ignore cometGen.tsx files in Knip #938

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion admin/knip.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"workspaces": {
".": {
"entry": ["./src/loader.ts"],
"ignore": ["./codegen.ts", "./schema.gql", "./src/**/generated/**/*.{ts,tsx}", "./src/**/*.cometGen.ts"],
"ignore": ["./codegen.ts", "./schema.gql", "./src/**/generated/**/*.{ts,tsx}", "./src/**/*.cometGen.{ts,tsx}"],

@manuelblum manuelblum Aug 25, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ignoring cometGen files, has other problems.

if a file, for example a validate function is only used in a cometGen file, those validate files will be marked as unused.

I think we should to set the cometGen files as entry files.

@johnnyomair johnnyomair Sep 1, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@manuelblum do you plan to do this in this PR?

@manuelblum manuelblum Sep 3, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still investigating into this. i will update this pr

"ignoreDependencies": ["@swc/plugin-emotion"],
"project": ["./src/**/*.{ts,tsx}"]
},
Expand Down