Ignore cometGen.tsx files in Knip - #938
Draft
manuelblum wants to merge 1 commit into
Draft
Conversation
manuelblum
changed the title
Contributor
Author
|
also configured similar in comet repository: https://github.com/vivid-planet/comet/blob/main/knip.json#L87 |
nsams
approved these changes
Aug 23, 2025
manuelblum
commented
Aug 25, 2025
| ".": { | ||
| "entry": ["./src/loader.ts"], | ||
| "ignore": ["./codegen.ts", "./schema.gql", "./src/**/generated/**/*.{ts,tsx}", "./src/**/*.cometGen.ts"], | ||
| "ignore": ["./codegen.ts", "./schema.gql", "./src/**/generated/**/*.{ts,tsx}", "./src/**/*.cometGen.{ts,tsx}"], |
Contributor
Author
There was a problem hiding this comment.
ignoring cometGen files, has other problems.
if a file, for example a validate function is only used in a cometGen file, those validate files will be marked as unused.
I think we should to set the cometGen files as entry files.
Contributor
Author
There was a problem hiding this comment.
still investigating into this. i will update this pr
johnnyomair
changed the title
johnnyomair
marked this pull request as draft
September 3, 2025 07:42
johnnyomair
removed their request for review
September 3, 2025 07:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This Pull Request updates the Knip configuration to ignore
cometGen.tsxfiles.False / Positive Error Message of unused file
Background:
.cometGenfiles are created ascometGen.ts.renderCell, the file must be renamed tocometGen.tsxto support JSX.