Surface PowerShell errors in viam update Windows PATH step#6111
Draft
allisonschiang wants to merge 1 commit into
Draft
Surface PowerShell errors in viam update Windows PATH step#6111allisonschiang wants to merge 1 commit into
viam update Windows PATH step#6111allisonschiang wants to merge 1 commit into
Conversation
addToWindowsUserPATH reduced any PowerShell failure to "exit status 1". Surface the real error instead: the read path includes exitErr.Stderr, and the write path switches Run() to CombinedOutput() so there is captured output to show. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
viambot
added
the
safe to test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
addToWindowsUserPATH(the Windows PATH step ofviam update) reduced any PowerShell failure toexit status 1, hiding the real cause. This surfaces PowerShell's actual output:GetEnvironmentVariable,.Output()): includeexitErr.StderrSetEnvironmentVariable): switch.Run()→.CombinedOutput()so there is captured output to showSame approach as the brew error-surfacing work. The structural swallow is verified, but this is a Windows-only path — draft until validated on a Windows machine (a PATH-write failure is rare to trigger naturally).
🤖 Generated with Claude Code