App 16855: Wire in UploadDataFromPath through RobotService#6102
Open
angelapredolac wants to merge 6 commits into
Open
App 16855: Wire in UploadDataFromPath through RobotService#6102angelapredolac wants to merge 6 commits into
angelapredolac wants to merge 6 commits into
Conversation
gloriacai01
reviewed
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira Ticket: Wire in UploadDataFromPath through RobotService
Summary
This wires the new UploadDataFromPath API through the RobotService (client, server, and robot interface) as a stub. The endpoint accepts a file or directory path plus optional upload metadata, routes the request from the robot to its configured data manager service, and returns aggregate upload results. The actual on-device upload logic lives in the data manager and is intentionally left for the follow-up ticket; this PR establishes the full request/response plumbing so that ticket only needs to implement the builtin's UploadDataFromPath method.
This is part of the on-robot data manager upload API (APP-15562). It depends on the api proto PR (#5917) and currently pins go.viam.com/api to that branch's commit; the final version bump to a released tag will happen once the api PR merges.
Changes
Testing
Unit Testing:
Manual Testing: N/A (no real upload behavior yet).
Notes