RSDK-14081: support Interactive shell on windows#6099
Open
allisonschiang wants to merge 4 commits into
Open
Conversation
allisonschiang
commented
Jun 11, 2026
| } | ||
| shellArgs = nil | ||
| shellEnv = nil | ||
| } |
Member
Author
There was a problem hiding this comment.
windows doesn't take the -i (interactive shell) or term input using nil here still works
allisonschiang
commented
Jun 11, 2026
| cmd := exec.CommandContext(ctxCancel, defaultShellPath, "-i") | ||
| cmd.Env = []string{"TERM=xterm-256color"} | ||
| f, err := pty.Start(cmd) | ||
| cmd := exec.Command(defaultShellPath, shellArgs...) |
Member
Author
There was a problem hiding this comment.
we pass the ctxCancel into xpty.WaitProcess on line 134 because exec can't launch a conPTY process
see: golang/go#62708
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces the unix-only pty with a charmbracelet/xpty which works on both unix and windows.
Testing:
This update is on the server-side, so I need to set up a viam-server with these updates and then shell into it
Mac -> Windows before:
Mac -> Windows after:
Also confirmed shelling into mac still works through windows -> mac running this viam-server