Skip to content

ci: grant check-approvals pull-requests:write so it can comment on PRs#6093

Merged
ale7714 merged 1 commit into
mainfrom
ci/fix-check-approvals-pr-comment-perms
Jun 8, 2026
Merged

ci: grant check-approvals pull-requests:write so it can comment on PRs#6093
ale7714 merged 1 commit into
mainfrom
ci/fix-check-approvals-pr-comment-perms

Conversation

@ale7714

@ale7714 ale7714 commented Jun 6, 2026

Copy link
Copy Markdown
Member

The check-approvals job posts a Review Required comment on the PR when approvals are unmet. That comment goes through the issues-comments endpoint, but for a pull request resource the GITHUB_TOKEN needs pull-requests: write -- issues: write does not cover PRs. The job only granted pull-requests: read + issues: write, so the POST returned 403 'Resource not accessible by integration' and crashed the check on every Claude PR at open time (e.g. #6087).

Verified on the same PR: assign-netcode-reviewer (pull-requests: write) edited the PR fine, while check-approvals (issues: write) 403'd -- confirming the scope, not the token/actor, is the issue. Brings this job in line with the other claude/* workflows (claude-pr-assistant, claude-ci-fix, claude-jira), which all already grant pull-requests: write.

The check-approvals job posts a Review Required comment on the PR when approvals are unmet. That comment goes through the issues-comments endpoint, but for a pull request resource the GITHUB_TOKEN needs pull-requests: write -- issues: write does not cover PRs. The job only granted pull-requests: read + issues: write, so the POST returned 403 'Resource not accessible by integration' and crashed the check on every Claude PR at open time (e.g. #6087).

Verified on the same PR: assign-netcode-reviewer (pull-requests: write) edited the PR fine, while check-approvals (issues: write) 403'd -- confirming the scope, not the token/actor, is the issue. Brings this job in line with the other claude/* workflows (claude-pr-assistant, claude-ci-fix, claude-jira), which all already grant pull-requests: write.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@viambot viambot added the safe to test This pull request is marked safe to test from a trusted zone label Jun 6, 2026
@ale7714 ale7714 merged commit ceb1fed into main Jun 8, 2026
21 checks passed
@ale7714 ale7714 deleted the ci/fix-check-approvals-pr-comment-perms branch June 8, 2026 01:28
JohnN193 pushed a commit to JohnN193/rdk that referenced this pull request Jun 9, 2026
viamrobotics#6093)

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
EvanDorsky pushed a commit to EvanDorsky/rdk that referenced this pull request Jun 12, 2026
viamrobotics#6093)

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test This pull request is marked safe to test from a trusted zone

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants