Skip to content

[RSDK-13303] Fix flaky TestRawClientOperation by draining stream before reading headers #6087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
viam-ci-org-reader wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −0
Open

[RSDK-13303] Fix flaky TestRawClientOperation by draining stream before reading headers #6087

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions robot/web/web_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1127,6 +1127,15 @@ func TestRawClientOperation(t *testing.T) {

echoStreamClient, err := echoclient.EchoMultiple(ctx, &echopb.EchoMultipleRequest{})
test.That(t, err, test.ShouldBeNil)
// Drain the stream before reading headers. Over WebRTC, the server-side stream
// can complete and cancel the context before Header() retrieves response metadata.
// Receiving all messages first ensures headers have arrived and are cached.
for {
_, recvErr := echoStreamClient.Recv()
if recvErr != nil {
break
}
}
md, err := echoStreamClient.Header()
test.That(t, err, test.ShouldBeNil)
checkOpID(md, true) // EchoMultiple is NOT filtered, so should have an opID
Expand Down
Loading