Repository navigation
fix(benchmarks): extension tool sessions, CRM base URL, and invoice principal types - #5499
Merged
Merged
Conversation
Signed-off-by: benpankow <ben.pankow@vercel.com>
Contributor
Signed-off-by: benpankow <ben.pankow@vercel.com>
benpankow
changed the title
![roboeve[bot]](https://avatars.githubusercontent.com/b/10660?s=60&v=4){kind=small}
Signed-off-by: benpankow <ben.pankow@vercel.com>
benpankow
changed the title
…and share it with hooks Signed-off-by: benpankow <ben.pankow@vercel.com>
Signed-off-by: benpankow <ben.pankow@vercel.com>
cmpadden
approved these changes
Oct 28, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In the re-run of
author-013-crm-extension, GPT-6.1 Terra's run 3 failed 4 tests with "Cannot read properties of undefined (reading 'turn')". Its tools readctx.session.turn.id, so they could require a lookup earlier in the same turn before adding a note. eve passes the session with every tool call, but the 013/014 graders' call context didn't, and their approval policies gotsession: {}. Both graders now pass a session with an ID, auth, and the current turn. That's the same shape the 012 grader already uses.The 013 prompt also now says which URL is the default. It used to say "some teams will point at our Acme sandbox instead of production (
https://api.acme-crm.dev)". With a.devaddress next to "sandbox", that read either way, and the grader expects the.devURL as thebaseUrldefault. In the re-run, Sonnet 5.5 madebaseUrlrequired and GPT-5.6 Terra defaulted to a made-uphttps://api.acme-crm.com, and both lost the default test for it. The prompt now reads: "Agents use our production API,https://api.acme-crm.dev, unless they set another base URL, since some teams point at our Acme sandbox instead."The 012 grader also stops requiring
principalType: "user". eve treats it as a free-form string and the prompt never mentions it. Haiku 5.5 used"tally_user"and lost only that test. The check now only fails non-person types (anonymous,app,local-dev,runtime,service), and still checksprincipalId.Validation
Rebuilt that run's project from its published results (with
eve extension buildfor@acme/crm), then ran both graders. Onmain, the 4 tool tests fail with that error. With this change they pass. Opus 5.5 run 1 (passing) and Sonnet 5.5 run 1 (realbaseUrldefault failure) grade the same before and after.Against Haiku's 012 run 1, the auth tests fail on
mainand pass with this change; Opus run 1 passes either way. The prompt change has no grader change to validate; 013 needs a re-run after this merges.🤖