Repository navigation
fix(benchmarks): approved extension tool calls, self-checking add_note, OpenCode read prompts - #5538
Merged
Merged
Conversation
Contributor
benpankow
force-pushed
the
benchmarks/fix-013-approval-and-opencode-read
branch
from
October 28, 2026 18:16
ba4171a to
7bac2f3
Compare
… add_note, and stop OpenCode asking Signed-off-by: benpankow <ben.pankow@vercel.com>
Signed-off-by: benpankow <ben.pankow@vercel.com>
…oints Signed-off-by: benpankow <ben.pankow@vercel.com>
benpankow
force-pushed
the
benchmarks/fix-013-approval-and-opencode-read
branch
from
October 28, 2026 23:46
7bac2f3 to
e173da9
Compare
OwenKephart
approved these changes
Oct 28, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
From the 013 re-run after #5499 and #5503:
ctx.approvalon that call. The 013/014 graders ranadd_noteandclose_ticketwithout it. Opus 5.5 checksctx.approvalinadd_noteas a second guard, in case a consuming agent re-defines the tool with a weaker policy, so runs 2 and 3 failed "add_note posts the note" and "honors a configured key and base URL". The graders now pass an approver to calls of tools that have an approval policy.add_notetake an email and look the customer up itself, so a note can't land on the wrong record. That's stronger than instructions, but it failed the test. The test now passes whenadd_note, given only an email, looks the customer up by it before posting. Otherwise it still requires the instructions fragment, now in a test renamed "gives the agent both tools and has it look customers up before notes". The check binds config through the extension handle, not the agent's mount, because the mount binds once and later tests depend on when..env.local. OpenCode's defaults ask before reading*.env/*.env.*and after three identical calls in a row (doom_loop), as well as for external directories, which fix(benchmarks): let OpenCode reach outside the project in authoring runs #5503 covered. The global config now allows all three. Those were the onlyaskrules inopencode debug agent build.Validation
Rebuilt the runs' projects from their published results over an
eve initscaffold of the same canary, and ran the old and new 013 graders:mainctx.approvalguard)add_notelooks up by email)add_notetakes a customer ID with no lookup and no instructionsThe 014 support-queue test still passes in the earlier scratch project. For OpenCode: against a mock model that reads the project's
.env.local, OpenCode 1.19.4 rejects it with #5503's config and completes with this one. Abashread outside the project still completes.🤖