Skip to content

fix: OSC 52 clipboard with execCommand fallback for user gesture requ… #1565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mdj2812 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: OSC 52 clipboard with execCommand fallback for user gesture requ… #1565

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions html/src/components/terminal/xterm/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,28 @@ export class Xterm {
terminal.loadAddon(fitAddon);
terminal.loadAddon(overlayAddon);
terminal.loadAddon(clipboardAddon);

// Workaround: navigator.clipboard.writeText() requires user activation,
// but OSC 52 sequences arrive asynchronously via PTY, outside the gesture
// window. Use execCommand('copy') as a fallback that doesn't require activation.
terminal.parser.registerOscHandler(52, (data: string) => {
const args = data.split(';');
if (args.length < 2 || args[1] === '?' || !args[1]) return false;
try {
const text = atob(args[1]);
const ta = document.createElement('textarea');
ta.value = text;
ta.style.cssText = 'position:fixed;opacity:0';
document.body.appendChild(ta);
ta.select();
document.execCommand('copy');
document.body.removeChild(ta);
return true;
} catch (_) {
return false;
}
});

terminal.loadAddon(webLinksAddon);

terminal.open(parent);
Expand Down