fix: OSC 52 clipboard with execCommand fallback for user gesture requ… - #1565
Open
mdj2812 wants to merge 1 commit into
Open
fix: OSC 52 clipboard with execCommand fallback for user gesture requ…#1565mdj2812 wants to merge 1 commit into
mdj2812 wants to merge 1 commit into
Conversation
…irement
navigator.clipboard.writeText() requires transient user activation,
but OSC 52 clipboard sequences arrive asynchronously from the PTY
server via WebSocket — outside the browser's gesture window.
Register an additional OSC 52 handler after the ClipboardAddon that
uses document.execCommand('copy') with a hidden textarea, which does
not require user activation.
Fixes clipboard integration for Neovim, tmux, and other terminal
programs that rely on OSC 52 sequences.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
@xterm/addon-clipboard uses navigator.clipboard.writeText() which requires transient user activation. OSC 52 clipboard sequences arrive asynchronously from the PTY server via WebSocket — outside the browser's gesture window. The browser silently rejects the write, so Neovim/tmux/any OSC 52 clipboard integration does not work.
Fix
Register an additional OSC 52 handler after the ClipboardAddon that uses document.execCommand('copy') with a hidden <textarea>. The older execCommand API does not require user activation, making it a reliable fallback for asynchronous clipboard writes.
Testing
printf "\e]52;c;%s\a" "$(echo "hello" | base64)"
Tested on Fedora 43, Chromium browser.