Skip to content

[trueforge-ui] show mcp server tool name on tool approval - #398

Merged
kumarsks619 merged 6 commits into
mainfrom
bugfix/FRONTEN-2349/tool-approval-tool-name
Aug 22, 2026
Merged

kumarsks619 merged 6 commits into
mainfrom
bugfix/FRONTEN-2349/tool-approval-tool-name

Conversation

@kumarsks619

@kumarsks619 kumarsks619 commented Aug 21, 2026 •

Copy link
Copy Markdown
Contributor

Summary

image

Closes #

Changes

How was this tested?

Checklist

  • I have read the contributing guidelines
  • pnpm build, pnpm test, pnpm typecheck, pnpm lint:ci, and pnpm format:check pass locally
  • Tests added/updated where it makes sense
  • No hand-edits to generated code (packages/trueforge-sdk, .github/fern/openapi/openapi.json, docs/openapi.json) — fork PRs omit SDK regen; maintainers regenerate after merge
  • Docs / .env.example updated if configuration or behavior changed

Note

Low Risk
Display-only UI change with existing parser reuse and unit tests; no auth, data, or approval-decision logic changes.

Overview
Tool approval now shows the inner MCP tool and server (e.g. search (github)) instead of the generic wrapper name like call_tool.

ToolApprovalContainer parses argsText via parseMcpToolArgs and falls back to the original toolName when MCP fields are missing. Tests cover both cases.

Reviewed by Cursor Bugbot for commit c54c8db. Bugbot is set up for automated code reviews on this repo. Configure here.

@changeset-bot

changeset-bot Bot commented Aug 21, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: c54c8db

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@truefoundry/trueforge-ui Patch
frontend Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kumarsks619 kumarsks619 added the ui label Aug 21, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit dcf8e54. Configure here.

@kumarsks619
kumarsks619 enabled auto-merge (squash) August 22, 2026 08:39
@kumarsks619
kumarsks619 merged commit d7015fd into main Aug 22, 2026
7 checks passed
@kumarsks619
kumarsks619 deleted the bugfix/FRONTEN-2349/tool-approval-tool-name branch August 22, 2026 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants