Repository navigation
M3: Agent + approval gates - #3
Conversation
- Make the /mcp loopback binding and its no-auth rationale explicit in agent/README.md's Prerequisites and Setup step 1, replacing vague "adjust the host" guidance with the actual safe path (put TrueForge on this project's Docker network, reach the server via http://chaos-mcp-server:3100) and an explicit warning against widening 127.0.0.1:3100:3100. - Extend the connector-reference-field caveat to flag the silent-failure risk: a clean manifest load is not proof the approval gate is wired if TrueForge ignores an unrecognized field instead of erroring. - Note that the TrueForge quickstart command follows TrueForge's own published docs, consistent with the caveat discipline used elsewhere. - Soften the root README's M3 status bullet so it no longer asserts the approval gate as a confirmed runtime property; matches agent/README.md's own framing that the manual walkthrough is the actual proof.
PR Summary by QodoAdd TrueForge chaos agent with human approval gates
AI Description
Diagram
High-Level Assessment
Files changed (4)
|
Code Review by Qodo
1.
|
- Add required mcp_servers[0].type ("truefoundry-mcp-registry") to the
manifest: TrueForge's manifest schema is a discriminated union and
requires this field even for a Connector-registered server, not just
a platform-catalog one — confirmed against TrueForge's own agent
manifest reference docs, resolving one of the two items previously
flagged "Unverified" in agent/README.md.
- Reorder "How to run an experiment" in the system prompt so
list_targets is called before stating intent, not after — the
original numbering had the agent describe what it expects to happen
before checking whether the target was already faulted, and
contradicted agent/README.md's own verification walkthrough, which
already expected list_targets first.
- Stop claiming list_targets can report a container as "healthy" —
it only returns Docker status and fault-registry state, no
application-health signal. Both the system prompt and the manual
verification walkthrough now say "Docker status running, no active
fault" and point at the dashboard for actual workload health.
- Fix the root README's M3 bullet, which read as though the approval
gate had already been verified against a live TrueForge instance.
It hasn't — that verification is manual and up to the user; the
bullet now says so plainly instead of using ambiguous present tense.
|
@qodo Addressed all 4 findings from the review in 380b76a:
Ready for a follow-up review. |
The changes in
The remaining validation is intentionally manual: load the manifest in a live TrueForge instance and confirm the approval prompt appears before a destructive tool executes. No further code-review issue is apparent from the updated diff. |
Adds the per-PR row for M3's Qodo review loop: 4 bugs found (1 High, 3 Medium), all fixed in 380b76a, follow-up review confirmed 0 remaining findings before merge.
Summary
Implements M3: a TrueForge agent manifest that turns M2's 7 MCP chaos tools into an actual agent, with human approval structurally required before any destructive action.
agent/chaos-notary.json— the agent manifest. System prompt describes the agent's actual capabilities (no fabricated blast-radius prediction or automated metrics access — those are M4/M5, not built).require_approval_for_toolsgates the 5 destructive tools (pause_container,stop_container,kill_container,inject_latency,inject_packet_loss) by exact name;list_targets(read-only) andclear_fault(a corrective/safety-restoring action) are ungated.agent/README.md— setup (registering themcp-serverMCP connector, loading the manifest) and a manual verification walkthrough that specifically checks the approval prompt fires before a destructive tool executes.README.mdupdated: M3 marked done, with wording that doesn't overclaim what this session actually verified (TrueForge is external — verification is manual, by you).Design doc:
docs/superpowers/specs/2026-08-27-m3-agent-approval-gates-design.mdImplementation plan:
docs/superpowers/plans/2026-08-27-m3-agent-approval-gates.mdBuilt via subagent-driven development: fresh implementer + independent reviewer per task, then a final whole-branch review (Opus) that cross-checked every factual claim in the system prompt against M2's actual source (tool names, allowlist, duration bounds, endpoint paths — all matched exactly) and caught 3 real documentation issues, since fixed:
/mcpendpoint PR M2: MCP server exposing chaos tools #2's Qodo review already locked down to loopback-only.Known gaps — this repo has no way to verify these
TrueForge is a real, very recently launched project (researched via web search/fetch, not prior training knowledge). Two manifest details couldn't be confirmed against a live instance and are explicitly flagged as "Unverified" in
agent/README.md, not asserted with false confidence:mcp_servers[0]field for referencing a Connector-registered custom MCP server (vs. TrueFoundry's own catalog).anthropic/claude-sonnet-5in the manifest).agent/README.md's manual verification walkthrough needs to actually be run.Test plan
node -e "require('./agent/chaos-notary.json')"— valid JSONservices/mcp-servertest suite unaffected — 56/56 passingmcp-serverconnector and load the manifest into a real TrueForge instance (needs Docker + TrueForge, unavailable in this sandbox — seeagent/README.md)agent/README.md's manual verification walkthrough, confirming the approval prompt actually fires before a destructive tool executes