Skip to content

[trueforge-ui] markdown link should open in new tab - #396

Merged
kumarsks619 merged 3 commits into
mainfrom
bugfix/FRONTEN-2348/markdown-link-open-new-tab
Aug 21, 2026
Merged

kumarsks619 merged 3 commits into
mainfrom
bugfix/FRONTEN-2348/markdown-link-open-new-tab

Conversation

@kumarsks619

@kumarsks619 kumarsks619 commented Aug 21, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Markdown links should open in new tab

Closes #

Changes

Screen.Recording.2026-08-21.at.5.26.19.PM.mov

How was this tested?

Checklist

  • I have read the contributing guidelines
  • pnpm build, pnpm test, pnpm typecheck, pnpm lint:ci, and pnpm format:check pass locally
  • Tests added/updated where it makes sense
  • No hand-edits to generated code (packages/trueforge-sdk, .github/fern/openapi/openapi.json, docs/openapi.json) — fork PRs omit SDK regen; maintainers regenerate after merge
  • Docs / .env.example updated if configuration or behavior changed

Note

Low Risk
Small UI-only change to link target behavior with a unit test; no auth, data, or security-logic changes. noopener noreferrer is included.

Overview
Markdown links in chat (and other Markdown usages) now open in a new tab instead of navigating the current page.

A custom a renderer on Markdown sets target="_blank" and rel="noopener noreferrer", and a unit test covers href, target, and rel.

Reviewed by Cursor Bugbot for commit 9dbe7ac. Bugbot is set up for automated code reviews on this repo. Configure here.

@changeset-bot

changeset-bot Bot commented Aug 21, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 9dbe7ac

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@truefoundry/trueforge-ui Patch
frontend Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 3bc452f. Configure here.

@qaifi-tf qaifi-tf added the ui label Aug 21, 2026
@kumarsks619
kumarsks619 enabled auto-merge (squash) August 21, 2026 13:18
@kumarsks619
kumarsks619 merged commit aa4be44 into main Aug 21, 2026
6 checks passed
@kumarsks619
kumarsks619 deleted the bugfix/FRONTEN-2348/markdown-link-open-new-tab branch August 21, 2026 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants