Skip to content

Commit aa4be44

Browse files
authored
[trueforge-ui] markdown link should open in new tab (#396)
1 parent 5520ca8 commit aa4be44

3 files changed

Lines changed: 22 additions & 0 deletions

File tree

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@truefoundry/trueforge-ui": patch
3+
---
4+
5+
Open markdown links in assistant messages in a new tab

‎packages/trueforge-ui/src/atoms/Markdown.tsx‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,14 @@ function makeComponents(opts: {
8080
} = opts;
8181

8282
return {
83+
// Chat markdown links should open in a new tab.
84+
a({ href, children, node: _node, ...props }) {
85+
return (
86+
<a {...props} href={href} target="_blank" rel="noopener noreferrer">
87+
{children}
88+
</a>
89+
);
90+
},
8391
// Strip default <pre> wrapper — each block renderer provides its own container.
8492
pre({ children }: { children?: ReactNode }) {
8593
return <>{children}</>;

‎packages/trueforge-ui/test/atoms/Markdown.test.tsx‎

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,15 @@ describe('Markdown', () => {
2929
expect(strong.closest('.markdown-body')).toBeTruthy();
3030
});
3131

32+
it('opens links in a new tab', () => {
33+
render(<Markdown content="See [docs](https://example.com/docs) for details." />);
34+
const link = screen.getByRole('link', { name: 'docs' });
35+
expect(link).toHaveAttribute('href', 'https://example.com/docs');
36+
expect(link).toHaveAttribute('target', '_blank');
37+
expect(link).toHaveAttribute('rel', 'noopener noreferrer');
38+
expect(link).not.toHaveAttribute('node');
39+
});
40+
3241
it('renders openui fenced blocks via OpenUiFenceBlock', async () => {
3342
render(<Markdown content={'```openui\nCard() { title: "Sales" }\n```'} />);
3443
await waitFor(() => {

0 commit comments

Comments
 (0)