Skip to content

feat(android): move ScrollableView to ViewPager2 #14396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hansemannn merged 13 commits into from
Mar 15, 2026
Merged

feat(android): move ScrollableView to ViewPager2 #14396

Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
a829042
feat(android): move to ViewPager2
m1ga Feb 23, 2026
33e088c
scrollType
m1ga Feb 23, 2026
94b77e6
fix package-lock
m1ga Feb 23, 2026
e247192
revert package-lock
m1ga Feb 23, 2026
91923dd
update workflows
m1ga Feb 24, 2026
635143c
Apply suggestion from @m1ga
m1ga Feb 26, 2026
5c5d910
fix disable scrolling
m1ga Feb 26, 2026
f4f8063
fix clipping
m1ga Feb 26, 2026
beff0eb
apply padding to correct view
m1ga Feb 26, 2026
dd2ab04
Merge branch 'androidViewPager2' of https://github.com/tidev/titanium…
m1ga Feb 26, 2026
dca9f38
Merge branch 'main' into androidViewPager2
m1ga Feb 26, 2026
912cec0
Merge branch 'main' into androidViewPager2
m1ga Mar 15, 2026
af85f2b
Merge branch 'main' into androidViewPager2
m1ga Mar 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/docs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@ jobs:
with:
fetch-depth: 0
- name: Use Node.js
uses: actions/setup-node@v4
uses: actions/setup-node@v6
with:
node-version: '20.x'
node-version: '24'
cache: 'npm'
Comment thread
m1ga marked this conversation as resolved.
Outdated
- run: npm ci
name: Install dependencies
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/regen-docs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,9 @@ jobs:
fetch-depth: 0

- name: Setup node
uses: actions/setup-node@v4
uses: actions/setup-node@v6
with:
node-version: '16'
node-version: '24'
Comment thread
m1ga marked this conversation as resolved.
Outdated
registry-url: 'https://registry.npmjs.org'

- name: Install dependencies
Expand Down
3 changes: 2 additions & 1 deletion android/modules/ui/src/java/ti/modules/titanium/ui/ScrollableViewProxy.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,8 @@
TiC.PROPERTY_CLIP_VIEWS,
TiC.PROPERTY_PADDING,
TiC.PROPERTY_SHOW_PAGING_CONTROL,
TiC.PROPERTY_OVER_SCROLL_MODE
TiC.PROPERTY_OVER_SCROLL_MODE,
TiC.PROPERTY_SCROLL_TYPE
})
public class ScrollableViewProxy extends TiViewProxy
{
Expand Down
Loading