feat(android): move ScrollableView to ViewPager2#14396
Merged
Merged
Conversation
|
No dependency changes detected. Learn more about Socket for GitHub. 👍 No dependency changes detected in pull request |
m1ga
commented
Feb 26, 2026
hansemannn
reviewed
Mar 15, 2026
hansemannn
reviewed
Mar 15, 2026
hansemannn
reviewed
Mar 15, 2026
hansemannn
reviewed
Mar 15, 2026
Collaborator
|
PR looks and works good - lete know when it's ready for review |
Contributor
Author
|
Thanks. Will run some last tests and then we should be good to go 👍 |
m1ga
marked this pull request as ready for review
March 15, 2026 13:39
Contributor
Author
|
Tested it with two different client apps where I didn't write the initial code and both behave the same way with the ViewPager2. And since all other tests worked fine too we should be good to go here 👍 |
hansemannn
approved these changes
Mar 15, 2026
cb1kenobi
pushed a commit
that referenced
this pull request
Mar 18, 2026
* feat(android): move to ViewPager2 * scrollType * fix package-lock * revert package-lock * update workflows * Apply suggestion from @m1ga * fix disable scrolling * fix clipping * apply padding to correct view
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #13690
the TabGroup stlil uses the ViewPager1 so I've kept it in the build.gradle file for now as this will only move the ScrollableView to ViewPager2. ViewPager2 supports RTL layouts or vertical orientation.
New feature:
scrollTypewithvertical(default ishorizontal). Same as theScrollViewTested:
scrollingEnabledtrue and falseTest:
use the KitchenSink App: Views - ScrollableView and with tidev/kitchensink-v2#75 for
scrollType: "vertical"Note:
🤖 AI generated! Have to do some more testing, but my first test in a real app looked fine already 👍
Bildschirmaufnahme_20260223_220124.webm