Skip to content

Make sure that the sample app does not crash #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jtorvald wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Make sure that the sample app does not crash #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ba242a0
Make sure that the sample does not crash on an iOS simulator and only…
jtorvald Oct 12, 2023
f9db97c
Check for physical device or any Android device for camera capturer
jtorvald Oct 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions The49.Twilio.Video.Maui/The49.Twilio.Video.Maui.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,18 +33,18 @@
<!--<PackageReference Include="The49.Twilio.Video.iOS" />-->
<ProjectReference Include="..\The49.Twilio.Video.iOS\The49.Twilio.Video.iOS.csproj" />
</ItemGroup>
<ItemGroup>
<None Include="..\LICENSE.md">
<Pack>True</Pack>
<PackagePath>\</PackagePath>
</None>
<None Include="..\logo.png">
<Pack>True</Pack>
<PackagePath>\</PackagePath>
</None>
<None Include="..\NUGET-README.md">
<Pack>True</Pack>
<PackagePath>\</PackagePath>
</None>
<ItemGroup>
<None Include="..\LICENSE.md">
<Pack>True</Pack>
<PackagePath>\</PackagePath>
</None>
<None Include="..\logo.png">
<Pack>True</Pack>
<PackagePath>\</PackagePath>
</None>
<None Include="..\NUGET-README.md">
<Pack>True</Pack>
<PackagePath>\</PackagePath>
</None>
</ItemGroup>
</Project>
54 changes: 38 additions & 16 deletions The49.Twilio.Video.Sample/VideoChatPage.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,21 +45,37 @@ protected async override void OnAppearing()
// Create the local audio track
_localAudioTrack = LocalAudioTrack.Create(true);

// Capture the video from the camera. We pick the front facing camera for now
var cameraCapturer = CameraCapturer.Create(CameraPosition.Front);
// Check if we have a virtual device. The iOS simulator does not have a camera
if (DeviceInfo.Current.DeviceType == DeviceType.Physical
|| DeviceInfo.Current.Platform == DevicePlatform.Android)
{
// Capture the video from the camera. We pick the front facing camera for now
var cameraCapturer = CameraCapturer.Create(CameraPosition.Front);

// Create the local video track from the camera capturer
_localVideoTrack = LocalVideoTrack.Create(true, cameraCapturer);

// Display the local video in the video view
_localVideoTrack.AddSink(localVideoView);

} else
{
_ = DisplayAlert("No Camera",
"iOS Simulator does not provide a camera. You will still see incoming video.",
"OK");
}

// Configure the connection options. Pass the token and the tracks we want to send to remote participants
var builder = new ConnectOptions.Builder(token)
.RoomName(RoomName);

// Create the local video track from the camera capturer
_localVideoTrack = LocalVideoTrack.Create(true, cameraCapturer);
if (_localVideoTrack != null)
builder.VideoTracks(new List<LocalVideoTrack> { _localVideoTrack });

// Display the local video in the video view
_localVideoTrack.AddSink(localVideoView);
if (_localAudioTrack != null)
builder.AudioTracks(new List<LocalAudioTrack> { _localAudioTrack });

// Configure the connection options. Pass the token and the tracks we want to send to remote participants
var options = new ConnectOptions.Builder(token)
.RoomName(RoomName)
.VideoTracks(new List<LocalVideoTrack> { _localVideoTrack })
.AudioTracks(new List<LocalAudioTrack> { _localAudioTrack })
.Build();
var options = builder.Build();

_room = TwilioVideoService.Default.Connect(options);

Expand All @@ -71,10 +87,16 @@ protected async override void OnAppearing()

protected override void OnDisappearing()
{
base.OnDisappearing();

_localVideoTrack.Release();
_localAudioTrack.Release();
base.OnDisappearing();

// remove events so we don't leak anything
_room.ConnectFailure -= OnRoomConnectFailure;
_room.Connected -= OnRoomConnected;
_room.ParticipantConnected -= OnParticipantConnected;

// null check
_localVideoTrack?.Release();
_localAudioTrack?.Release();
_room.Disconnect();
}

Expand Down