Make sure that the sample app does not crash#1
Open
jtorvald wants to merge 2 commits into
Open
Conversation
… add a video track when there is a camera
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First of all, thanks a lot for sharing this work!
I'm one of the maintainers from https://github.com/xamarin-bindings-for-twilio and I was just looking into making the Twilio bindings work with .NET Maui since I need it for one of my clients. This project helps me and my client enormous!
I tried the sample code and ran into some issues on the simulator since it does not have a camera. Therefor I thought I send a PR to fix that so it's easier for new people to start with this project.
I will try to do the same implementation as we have in our Xamarin Native apps with this library and see how far I come. If there are issues I will report them and try to fix them as well.
Thanks a lot.