refactor(DT-3906): Migrate workflow client-action modals to runes (carved from #3370 - Part 4)#3375
Merged
tegan-temporal merged 4 commits intoMay 7, 2026
Conversation
…runes
Migrates the workflow action confirmation modals + supporting form/button.
All modals share the same pattern (props + on-submit/cancel callbacks).
- workflow/client-actions/batch-{cancel,reset,terminate}-confirmation-modal.svelte
- workflow/client-actions/{cancel,reset,signal,terminate}-confirmation-modal.svelte
- workflow/client-actions/batch-operation-confirmation-form.svelte
- workflow/download-event-history-modal.svelte
- workflow/start-workflow-button.svelte
Carved out of #3370 to make the migration PR easier to review.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
tegan-temporal
changed the title
tegan-temporal
changed the title
rossnelson
approved these changes
May 7, 2026
tegan-temporal
commented
May 7, 2026
Co-authored-by: Tegan Churchill <tegan.churchill@temporal.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates 10 workflow client-action components to Svelte 5 runes — the confirmation modals (cancel/reset/terminate/signal + batch variants), the batch-operation form, the download-event-history modal, and the start-workflow button.
All modals share the same prop/callback shape — review one and the others are mechanical.
Files:
10 files, +172 / -91. Carved out of #3370.
Test plan
Context
Part of DT-3906 Svelte 4→5 migration. Highest review value of the carve-outs — these touch user-visible behavior.