Codefreeze 05.01.26 to main#3384
Merged
Merged
Conversation
* Update translate to svelte 5 syntax * Update PageTitle to Svelte 5 syntax * Update Panel to Svelte 5 syntax * Update PayloadInput * Update WorkflowStatus to svelte 5 syntax * Update BatchOperations Table to Svelte 5 syntax * Update Icon and Svg components to Svelte 5 syntax * Update Error to Svelte 5 syntax * Update Keyboard Short components to Svelte 5 syntax * Update Label component Svelte 5 syntax * Update TabPanel to Svelte 5 syntax * Update Combobox async-test to Svelte 5 syntax * Update Logo to Svelte 5 syntax * Update Batch Operations Page to Svelte 5 syntax * Update (app) +page to Svelte 5 syntax * Update NameSpace page to Svelte 5 syntax * update UserMenuMobile to Svelte 5 syntax * Update Lines and Dots components to Svelte 5 syntax * Use worse type to not introduce more errors * Migrate forgotten lines and dots component to Svelte 5 syntax * Change derived state to reactive state in async combobox test
…le (#3344) * Fix eslint warning * Migrate to Svelte 5 syntax * Add multiselect via shift key * Clear prev index after page selected or all selected trigger * Make onClickBatchSelect optional, disable checkbox if child * Do not set child disabled * Support shift+click select within child workflows * Update shift+click logic. Instead of multiple scopes, treat all visible items as one scope. * Remove console log * Fixup type * Add tests * Account for prevClickedRow being nullish * Fix type * Fix some warnings * Fix type * Fix type for onClickBatchSelect * Fix type check * Use early return * More warning fixes * Undo prop type change * Fix warning * Default query to empty string * Move comment to inside handler :\ * Move isChecked higher * Fix race condition * Fix the fix :P * Use runId as key * use runId for check * Show root rows as checked if allSelected * Use map instead of set so we rely on runId for equality * Fix header checkmark status * Address PR comments * Apply suggestions from code review Co-authored-by: Laura Whitaker <laura.k.whitaker@gmail.com> --------- Co-authored-by: Laura Whitaker <laura.k.whitaker@gmail.com>
* Enable Svelte 5 runes on files not using legacy features * Migrate components to Svelte 5 runes syntax * Trivial migrations * More simple migrations * feat(DT-3657): Support shift click for bulk selection in workflow table (#3344) * Fix eslint warning * Migrate to Svelte 5 syntax * Add multiselect via shift key * Clear prev index after page selected or all selected trigger * Make onClickBatchSelect optional, disable checkbox if child * Do not set child disabled * Support shift+click select within child workflows * Update shift+click logic. Instead of multiple scopes, treat all visible items as one scope. * Remove console log * Fixup type * Add tests * Account for prevClickedRow being nullish * Fix type * Fix some warnings * Fix type * Fix type for onClickBatchSelect * Fix type check * Use early return * More warning fixes * Undo prop type change * Fix warning * Default query to empty string * Move comment to inside handler :\ * Move isChecked higher * Fix race condition * Fix the fix :P * Use runId as key * use runId for check * Show root rows as checked if allSelected * Use map instead of set so we rely on runId for equality * Fix header checkmark status * Address PR comments * Apply suggestions from code review Co-authored-by: Laura Whitaker <laura.k.whitaker@gmail.com> --------- Co-authored-by: Laura Whitaker <laura.k.whitaker@gmail.com> * Delete unused file --------- Co-authored-by: Laura Whitaker <laura.k.whitaker@gmail.com>
* Export MultiSelectionOptions type * Migrate components/event components * Fix type error
* chore: upgrade TypeScript to v6.0.3 - Bump typescript from ^5.2.2 to 6.0.3 - Add explicit `strict: false` to tsconfig to preserve existing behavior (TS 6 now defaults strict to true) - Fix two event handler type errors caused by TS 6 DOM lib typing on:input as InputEvent instead of Event * chore: add @typescript/native-preview for tsgo support Enables `svelte-check --tsgo` and `svelte-check --tsgo --incremental` for faster type checking using the Go-based TypeScript compiler. * chore: enable --tsgo --incremental for svelte-check Faster type checking via Go-based TS compiler with disk-cached svelte2tsx transpilation. Will report errors in 4 unmigrated Svelte 4 components until they are converted to Svelte 5 runes. * ts-upgrade: Migrate chip-input to fix tsgo error (#3380) * Fix tsgo union too complex error (#3381) * fix: replace redundant comma operator reactive statements $: (dep, fn()) is unnecessary when fn() already reads dep internally. Replaced with $: fn() which Svelte tracks as a dependency automatically. * fix: preserve reactive dependencies using block instead of comma operator Replaces $: (dep, fn()) with $: { dep; fn(); } to keep the explicit dependency declaration while avoiding the tsgo comma operator error. --------- Co-authored-by: Tegan Churchill <tegan.churchill@temporal.io>
… Svelte 5 runes (#3377)
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![temporal-cicd[bot]](https://avatars.githubusercontent.com/in/357945?s=60&v=4){kind=small}
| ? options.filter((o) => $eventClassificationFilter.includes(o.value)) | ||
| : [], | ||
| ); | ||
|
|
Contributor
There was a problem hiding this comment.
⚠️ Parameter '_options' implicitly has an 'any' type.
| <div class="cursor-pointer overflow-auto {$$restProps.class}"> | ||
| <div class="cursor-pointer overflow-auto {className}"> | ||
| <TimelineGraph | ||
| {viewportHeight} |
Contributor
There was a problem hiding this comment.
⚠️ Type 'WorkflowExecution | undefined' is not assignable to type 'WorkflowExecution'.
| <div class="cursor-pointer overflow-auto {className}"> | ||
| <TimelineGraph | ||
| {viewportHeight} | ||
| {workflow} |
Contributor
There was a problem hiding this comment.
⚠️ Argument of type 'WorkflowExecution | undefined' is not assignable to parameter of type 'WorkflowExecution'.
| } | ||
| }); | ||
|
|
||
| function handleNullFilter() { |
Contributor
There was a problem hiding this comment.
⚠️ Type 'null' is not assignable to type 'string'.
| taskFailure = false, | ||
| 'test-id': testId, | ||
| }: Props = $props(); | ||
|
|
Contributor
There was a problem hiding this comment.
⚠️ Type 'string | null' does not satisfy the constraint 'string | number | symbol'.
| const workflowEvents = $derived( | ||
| getWorkflowStartedCompletedAndTaskFailedEvents($fullEventHistory), | ||
| ); | ||
| const isPending = $derived( |
Contributor
There was a problem hiding this comment.
⚠️ '$workflowRun.workflow' is possibly 'null'.⚠️ '$workflowRun.workflow' is possibly 'null'.
|
|
||
| $: canceled = ['Terminated', 'TimedOut', 'Canceled'].includes( | ||
| workflow?.status, | ||
| const canceled = $derived( |
Contributor
There was a problem hiding this comment.
⚠️ Argument of type 'string | null | undefined' is not assignable to parameter of type 'string'.
| ['Terminated', 'TimedOut', 'Canceled'].includes(workflow?.status), | ||
| ); | ||
| </script> | ||
|
|
Contributor
There was a problem hiding this comment.
⚠️ 'pendingActivities' is possibly 'undefined'.
| const handlePaste = (e: ClipboardEvent) => { | ||
| e.preventDefault(); | ||
| if (maxLength && $values.length >= maxLength) return; | ||
| if (maxLength && chips.length >= maxLength) return; |
Contributor
There was a problem hiding this comment.
⚠️ 'e.clipboardData' is possibly 'null'.
| replace = undefined, | ||
| children, | ||
| }: Props = $props(); | ||
|
|
Contributor
There was a problem hiding this comment.
⚠️ Argument of type '{ count: number | undefined; }' is not assignable to parameter of type 'I18nReplace'.
Contributor
|
laurakwhit
approved these changes
May 11, 2026
tegan-temporal
approved these changes
May 11, 2026
tegan-temporal
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description & motivation 💭
Merges the
codefreeze-05.01.26release branch back intomain. Includes the following PRs (in branch order, newest at the top):Screenshots (if applicable) 📸
N/A — no new UI; see the individual PRs for any per-feature screenshots.
Design Considerations 🎨
N/A — no design changes; this is a release-branch roll-up.
Testing 🧪
How was this tested 👻
Each included PR was reviewed and tested individually before being merged into
codefreeze-05.01.26. CI on the codefreeze branch has been green.Steps for others to test: 🚶🏽♂️🚶🏽♀️
Smoke-test the app end-to-end after merging, with extra attention to:
These areas saw the most Svelte 5 rune migration churn.
Checklists
Draft Checklist
Merge Checklist
Issue(s) closed
See the individual PRs linked above for any issue references.
Docs
Any docs updates needed?
No — covered by the individual PRs where applicable.