Fix: LSP spawns planted project node_modules/.bin binaries on host (RCE, sandbox bypass) - #343
Contributor trust inconclusive
Investigator 1 (shard 1 of 3) reviewed PR #343 in superagent-ai/grok-cli, which is the current PR. The patch removes the findLocalBinary helper from src/lsp/builtins.ts, eliminating resolution of binaries from the project's own node_modules/.bin in favor of PATH-only resolution via findCommandOnPath. The change is accompanied by a clear security comment explaining the host RCE risk from planted project executables and directs users to explicit builtins..command overrides in .grok/settings.json. The diff contains no new network paths, no obfuscation, no dependency/package/script changes, no CI modifications, and no permission broadening; it reduces attack surface by removing a local-binary spawn path. This shard contains only 1 of 2 candidate PRs, so a confident contributor-level verdict cannot be reached without the other shard's findings. Reviewed PR #340 (superagent-ai/grok-cli). The hydrated patch in src/utils/settings.ts is a clean security-hardening change: it removes trust in repo-committed .grok/settings.json for sandbox mode and sandbox settings, restricting those values to user settings only. No suspicious signals, hidden network calls, obfuscation, or lifecycle changes were found. However, this shard contains only 1 of 2 candidate PRs, and the contributor (a bot with zero other observable GitHub activity) cannot be confidently assessed without the other candidate PR.