Skip to content

Fix: LSP spawns planted project node_modules/.bin binaries on host (RCE, sandbox bypass) #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
superagent-security-dev wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: LSP spawns planted project node_modules/.bin binaries on host (RCE, sandbox bypass) #343

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions src/lsp/builtins.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,8 +318,13 @@ function createCustomRuntimeDefinition(cwd: string, config: LspCustomServerConfi
}

async function resolveCommand(root: string, binary: string): Promise<string | null> {
const localBinary = await findLocalBinary(root, binary);
if (localBinary) return localBinary;
// Do not resolve or spawn binaries from the project's own node_modules/.bin.
// A malicious repository can plant an executable there that would run on the
// host with the developer's privileges, outside the Shuru sandbox and with no
// workspace-trust gate (LSP servers are always spawned on the host). Project
// pinned language servers must be configured explicitly via the
// builtins.<id>.command override in .grok/settings.json instead.
void root;
return findCommandOnPath(binary);
}

Expand All @@ -338,12 +343,6 @@ async function resolveTypeScriptServer(root: string): Promise<string | null> {
return null;
}

async function findLocalBinary(root: string, binary: string): Promise<string | null> {
const ext = process.platform === "win32" ? ".cmd" : "";
const candidate = path.join(root, "node_modules", ".bin", `${binary}${ext}`);
return (await pathExists(candidate)) ? candidate : null;
}

async function resolveNodeServerLaunch(
root: string,
binary: string,
Expand Down
Loading