Skip to content
This repository was archived by the owner on May 20, 2026. It is now read-only.

ENG-1048: Bump path-to-regexp / hono / flatted cluster - #23

Closed
mjohnsonsu wants to merge 1 commit into
mainfrom
eng-1048/bump-cluster-4
Closed

ENG-1048: Bump path-to-regexp / hono / flatted cluster#23
mjohnsonsu wants to merge 1 commit into
mainfrom
eng-1048/bump-cluster-4

Conversation

@mjohnsonsu

Copy link
Copy Markdown
Contributor

🔧 Change Summary

Clears 5 HIGH CVEs (SLA 2026-04-28/29) in both pnpm workspaces:

package before after CVE
path-to-regexp 8.3.0 8.4.2 CVE-2026-4926
express-rate-limit 8.2.1 8.3.2 CVE-2026-30827
@hono/node-server 1.19.9 1.19.14 CVE-2026-29087
hono 4.12.8 4.12.14 CVE-2026-29045
flatted 3.3.4 3.4.2 CVE-2026-33228 + CVE-2026-32141

Four of the five updated via the existing semver ranges + `pnpm update --lockfile-only`. `flatted` required an additional `pnpm.overrides` entry in `typescript/package.json` (next to the existing `handlebars`/`langsmith`/`hono` overrides) because `flat-cache@4.0.1` pins `flatted: 3.3.4` as an exact transitive in the lockfile — `pnpm update` refused to move it without the override.

📋 Linked Linear Ticket

  • references ENG-1048

🧪 How Was This Tested?

  • Verified all 5 packages resolve to patched versions in both `typescript/pnpm-lock.yaml` and `modelcontextprotocol/pnpm-lock.yaml`.
  • Lockfile-only change (apart from the one-line `flatted` override).
  • Reverted incidental cosmetic devDep bumps that `pnpm update` tried to make to `modelcontextprotocol/package.json` — keeps the diff focused on security fixes.

🔐 Security Consideration

Direct CVE remediation.

🚀 Deployment & Validation Plan

  • Deployment Method: Merge → existing release pipeline for `@subtotal-inc/ai-toolkit`.
  • Target Environment: npm publish.
  • Post-Deployment Validation Steps: Vanta resync will drop the 5 CVEs from this repo.

🔁 Rollback Plan

Revert this commit.

📄 Change Type

  • Dependency update

🤖 Generated with Claude Code

Clears the following HIGH CVEs (SLA 2026-04-28/29) in both pnpm
workspaces (typescript, modelcontextprotocol):

  path-to-regexp      8.3.0  → 8.4.2   CVE-2026-4926
  express-rate-limit  8.2.1  → 8.3.2   CVE-2026-30827
  @hono/node-server   1.19.9 → 1.19.14 CVE-2026-29087
  hono                4.12.8 → 4.12.14 CVE-2026-29045
  flatted             3.3.4  → 3.4.2   CVE-2026-33228 + CVE-2026-32141

Four of the five updated via the existing range + `pnpm update`.
`flatted` is a transitive of `flat-cache@4.0.1` which pins it via an
exact `dependencies: { flatted: 3.3.4 }` entry in the lockfile; pnpm
`update` refused to move it without an override. Added
`"flatted": ">=3.4.2"` to the existing `pnpm.overrides` block in
`typescript/package.json` (same block as hono/handlebars/langsmith).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
mjohnsonsu pushed a commit that referenced this pull request Apr 17, 2026
Both are no longer load-bearing — natural resolution from each
transitive's range already satisfies the security floor:

  handlebars  ^4.7.9   → 4.7.9   (unchanged)
  hono        >=4.12.7 → 4.12.14 (matches the cluster-4 bump)

The remaining two overrides (langsmith, flatted) stay:
- `langsmith >=0.4.6` — without it, 0.3.87 reappears alongside 0.5.11
- `flatted >=3.4.2` (added in this branch's parent commit) — without
  it, flat-cache@4.0.1 keeps flatted pinned to 3.3.4 in the lockfile

Stacked on top of eng-1048/bump-cluster-4 (PR #23) since both
commits touch the same `pnpm.overrides` block.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
mjohnsonsu pushed a commit that referenced this pull request Apr 17, 2026
Combined PR — supersedes #23 (cluster-4 bumps + flatted override) and
#24 (drop redundant handlebars/hono overrides).

CVE bumps in both workspaces (typescript, modelcontextprotocol):
  path-to-regexp     8.3.0  → 8.4.2   (CVE-2026-4926)
  express-rate-limit 8.2.1  → 8.3.2   (CVE-2026-30827)
  @hono/node-server  1.19.9 → 1.19.14 (CVE-2026-29087)
  hono               4.12.8 → 4.12.14 (CVE-2026-29045)
  flatted            3.3.4  → 3.4.2   (CVE-2026-33228 + CVE-2026-32141)

pnpm.overrides reshuffle in typescript/package.json:
  + flatted: ">=3.4.2"   (required — flat-cache@4.0.1 pins flatted: 3.3.4
                          in the lockfile; pnpm update refuses to move it)
  - handlebars: "^4.7.9" (no longer load-bearing — natural is 4.7.9)
  - hono: ">=4.12.7"     (no longer load-bearing — natural matches the bump)

langsmith override stays — without it, 0.3.87 reappears alongside 0.5.x.

Reverted incidental cosmetic devDep bumps that pnpm update tried to
make to modelcontextprotocol/package.json.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@mjohnsonsu

Copy link
Copy Markdown
Contributor Author

Superseded by #25 (consolidated).

@mjohnsonsu mjohnsonsu closed this Apr 17, 2026
@mjohnsonsu
mjohnsonsu deleted the eng-1048/bump-cluster-4 branch April 17, 2026 11:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants