Skip to content
This repository was archived by the owner on May 20, 2026. It is now read-only.

ENG-1048: Drop redundant handlebars / hono pnpm overrides (stacked) - #24

Closed
mjohnsonsu wants to merge 1 commit into
eng-1048/bump-cluster-4from
eng-1048/drop-redundant-overrides
Closed

ENG-1048: Drop redundant handlebars / hono pnpm overrides (stacked)#24
mjohnsonsu wants to merge 1 commit into
eng-1048/bump-cluster-4from
eng-1048/drop-redundant-overrides

Conversation

@mjohnsonsu

Copy link
Copy Markdown
Contributor

🔧 Change Summary

Stacked on top of #23. Drops two now-redundant entries from `pnpm.overrides`:

override floor natural status
`handlebars ^4.7.9` 4.7.9 4.7.9 redundant
`hono >=4.12.7` 4.12.7 4.12.14 redundant (matches the cluster-4 bump in #23)

Remaining overrides stay:

📋 Linked Linear Ticket

  • references ENG-1048

🧪 How Was This Tested?

  • Removed each candidate, ran `pnpm install --lockfile-only`, confirmed no version regressions.

🔐 Security Consideration

No regression. All previously-floored packages remain at or above the CVE fix versions.

⚠️ Merge order

Merge after #23 (this PR is stacked on it). GitHub will rebase the diff cleanly once #23 is in.

🚀 Deployment & Validation Plan

  • Deployment Method: Merge → existing release pipeline.
  • Target Environment: npm publish.
  • Post-Deployment Validation Steps: None expected; same resolved versions.

🔁 Rollback Plan

Revert this commit.

📄 Change Type

  • Dependency update (cleanup)

🤖 Generated with Claude Code

Both are no longer load-bearing — natural resolution from each
transitive's range already satisfies the security floor:

  handlebars  ^4.7.9   → 4.7.9   (unchanged)
  hono        >=4.12.7 → 4.12.14 (matches the cluster-4 bump)

The remaining two overrides (langsmith, flatted) stay:
- `langsmith >=0.4.6` — without it, 0.3.87 reappears alongside 0.5.11
- `flatted >=3.4.2` (added in this branch's parent commit) — without
  it, flat-cache@4.0.1 keeps flatted pinned to 3.3.4 in the lockfile

Stacked on top of eng-1048/bump-cluster-4 (PR #23) since both
commits touch the same `pnpm.overrides` block.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
mjohnsonsu pushed a commit that referenced this pull request Apr 17, 2026
Combined PR — supersedes #23 (cluster-4 bumps + flatted override) and
#24 (drop redundant handlebars/hono overrides).

CVE bumps in both workspaces (typescript, modelcontextprotocol):
  path-to-regexp     8.3.0  → 8.4.2   (CVE-2026-4926)
  express-rate-limit 8.2.1  → 8.3.2   (CVE-2026-30827)
  @hono/node-server  1.19.9 → 1.19.14 (CVE-2026-29087)
  hono               4.12.8 → 4.12.14 (CVE-2026-29045)
  flatted            3.3.4  → 3.4.2   (CVE-2026-33228 + CVE-2026-32141)

pnpm.overrides reshuffle in typescript/package.json:
  + flatted: ">=3.4.2"   (required — flat-cache@4.0.1 pins flatted: 3.3.4
                          in the lockfile; pnpm update refuses to move it)
  - handlebars: "^4.7.9" (no longer load-bearing — natural is 4.7.9)
  - hono: ">=4.12.7"     (no longer load-bearing — natural matches the bump)

langsmith override stays — without it, 0.3.87 reappears alongside 0.5.x.

Reverted incidental cosmetic devDep bumps that pnpm update tried to
make to modelcontextprotocol/package.json.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@mjohnsonsu

Copy link
Copy Markdown
Contributor Author

Superseded by #25 (consolidated).

@mjohnsonsu
mjohnsonsu deleted the branch eng-1048/bump-cluster-4 April 17, 2026 11:18
@mjohnsonsu mjohnsonsu closed this Apr 17, 2026
@mjohnsonsu
mjohnsonsu deleted the eng-1048/drop-redundant-overrides branch April 17, 2026 11:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants