Skip to content

Return error when query returns too many pages #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mathukumillia wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Return error when query returns too many pages #30

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion pkg/plugin/sift_api_queries.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,9 +194,13 @@ func handlePaginatedRequest[T any](

results = append(results, items...)

// If there's no next page nextPageToken, break out of the loop.
if nextPageToken == "" {
// If there's no nextPageToken, break out of the loop.
break
} else if i == maxPages-1 {
// If there is a nextPageToken but we've already hit our maxPages
// limit, return an error.
return nil, fmt.Errorf("query generated too many pages (>%d) of results, data has been dropped", maxPages)
}
params.Set("page_token", nextPageToken)
}
Expand Down
Loading