Return error when query returns too many pages#30
Open
mathukumillia wants to merge 1 commit intosift-stack:mainfrom
Open
Return error when query returns too many pages#30mathukumillia wants to merge 1 commit intosift-stack:mainfrom
mathukumillia wants to merge 1 commit intosift-stack:mainfrom
Conversation
Modifes the handlePaginatedRequest function to return an error when the number of pages returned exceeds the statically configured limit. Without this, the returned data is arbitrarily truncated, leading to potentially misleading data and dashboards.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Modifes the handlePaginatedRequest function to return an error when the number of pages returned exceeds the statically configured limit. Without this, the returned data is arbitrarily truncated, leading to potentially misleading data and dashboards.
Type of change
Please check the boxes that apply to this pull request.
How Has This Been Tested?
I ran a Grafana instance locally that returned more than one page and ensured it returned an error.
Checklist
Screenshots