Skip to content

docs(tabs): show tooltip in si-tabs-icons example #1872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
spliffone wants to merge 1 commit into
base: main
Choose a base branch
from
Open

docs(tabs): show tooltip in si-tabs-icons example #1872

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...ots/si-tabs--si-tabs-icons--tabs-icons-element-examples-chromium-dark-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions ...ts/si-tabs--si-tabs-icons--tabs-icons-element-examples-chromium-light-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions src/app/examples/si-tabs/si-tabs-icons.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
<si-tabset>
@for (tab of tabs; track tab) {
<si-tab
[siTooltip]="tab.heading"
Comment thread
spliffone marked this conversation as resolved.
[isDisabled]="!tab.heading || tab.disabled"
[disabled]="tab.disabled"
[active]="tab.active ?? false"
Copy link
Copy Markdown
Member

@chintankavathia chintankavathia Apr 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

example has some more issues. disabled property is not applied. lobby icon tab doesn't show the si-tooltip rather showing native html title tooltip

[badgeColor]="tab.badgeColor"
[badgeContent]="tab.badgeContent"
Expand Down
3 changes: 2 additions & 1 deletion src/app/examples/si-tabs/si-tabs-icons.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
*/
import { ChangeDetectionStrategy, Component, inject } from '@angular/core';
import { SiTabComponent, SiTabsetComponent } from '@siemens/element-ng/tabs';
import { SiTooltipDirective } from '@siemens/element-ng/tooltip';
import { LOG_EVENT } from '@siemens/live-preview';

interface TabModel {
Expand All @@ -18,7 +19,7 @@ interface TabModel {

@Component({
selector: 'app-sample',
imports: [SiTabsetComponent, SiTabComponent],
imports: [SiTabsetComponent, SiTabComponent, SiTooltipDirective],
templateUrl: './si-tabs-icons.html',
changeDetection: ChangeDetectionStrategy.OnPush,
host: { class: 'p-5' }
Expand Down
Loading