docs(tabs): show tooltip in si-tabs-icons example#1872
docs(tabs): show tooltip in si-tabs-icons example#1872
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds tooltips to the tab icons in the si-tabs example by importing the SiTooltipDirective and applying it to the si-tab components. A suggestion was made to bind the [isDisabled] input to the presence of the tooltip text to avoid creating unnecessary tooltip instances with ARIA attributes when the content is empty.
spliffone
force-pushed
the
docs/icon-tab-with-tooltip
branch
2 times, most recently
from
8455c9c to
b253f01
Compare
| <si-tab | ||
| [siTooltip]="tab.heading" | ||
| [isDisabled]="!tab.heading || tab.disabled" | ||
| [active]="tab.active ?? false" |
There was a problem hiding this comment.
example has some more issues. disabled property is not applied. lobby icon tab doesn't show the si-tooltip rather showing native html title tooltip
spliffone
force-pushed
the
docs/icon-tab-with-tooltip
branch
from
b253f01 to
60ecb2b
Compare
spliffone
added
the
core-team-discussion
spike-rabbit
left a comment
spike-rabbit
left a comment
There was a problem hiding this comment.
Let please wait a little before we introduce an example here. The idea is to come-up with a new directive/service we use internally to set a tooltip automatically, but allows overriding it by applications
kfenner
removed
the
core-team-discussion
4 participants
Extend si-tabs-icons example to show tooltips
See https://code.siemens.com/simpl/simpl-element/-/work_items/2691
Documentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: