fix(tests): drop a cross-package import that has silently skipped since io 0.3.0 - #365
Open
ywatanabe1989 wants to merge 1 commit into
Open
fix(tests): drop a cross-package import that has silently skipped since io 0.3.0#365ywatanabe1989 wants to merge 1 commit into
ywatanabe1989 wants to merge 1 commit into
Conversation
…ce io 0.3.0 `scitex_io._load_modules._sqlite3` is in the parametrized list of cross-package modules that `test_cross_package_import` walks. That module was DELETED in scitex-io 0.3.0 and does not exist on origin/develop today. It does not fail. The test body calls `_import_or_skip_if_snapshot_drifted(module_name)`, so an absent module SKIPS and the case reports green. It has been reporting green while checking nothing for as long as the module has been gone. That is the shape this fleet keeps finding: a gate that cannot fail. It is the same class as PS-140 in scitex-io — `importorskip` on the FULL path, so a renamed or deleted submodule silently skips rather than surfacing — which was fixed there this week with a negative control proving the pre-fix case SKIPPED (green) and the post-fix case FAILED. Removing the entry costs nothing and is honest: the module is gone, so there is no cross-package import to assert. The remaining entries in that list are unaffected. Incidentally this is also the last occurrence of the string in this file, and one of only three in the whole repository, the other two being a stdlib module-name list and an assertion about `scitex-db`'s public `SQLite3` class — scitex-db being the operator's one granted exemption, a database LIBRARY rather than SciTeX state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(tests): drop a cross-package import that has silently skipped since io 0.3.0
scitex_io._load_modules._sqlite3is in the parametrized list of cross-packagemodules that
test_cross_package_importwalks. That module was DELETED inscitex-io 0.3.0 and does not exist on origin/develop today.
It does not fail. The test body calls
_import_or_skip_if_snapshot_drifted(module_name), so an absent module SKIPS andthe case reports green. It has been reporting green while checking nothing for as
long as the module has been gone.
That is the shape this fleet keeps finding: a gate that cannot fail. It is the
same class as PS-140 in scitex-io —
importorskipon the FULL path, so a renamedor deleted submodule silently skips rather than surfacing — which was fixed there
this week with a negative control proving the pre-fix case SKIPPED (green) and the
post-fix case FAILED.
Removing the entry costs nothing and is honest: the module is gone, so there is no
cross-package import to assert. The remaining entries in that list are unaffected.
Incidentally this is also the last occurrence of the string in this file, and one
of only three in the whole repository, the other two being a stdlib module-name
list and an assertion about
scitex-db's publicSQLite3class — scitex-db beingthe operator's one granted exemption, a database LIBRARY rather than SciTeX state.