chore(sqlite-out): the retired engine's name reaches zero (20 files -> 0), and two committed databases go with it - #372
Merged
Conversation
…s/adr We do not use the retired embedded engine; runtime state lives in PostgreSQL. Its name survived in 20 tracked files. This clears all of them, keeping only docs/adr/ (untouched) and the Zotero/Optuna integrations (which carry none). Deleted outright: - `.scitex/clew/runtime/db.sqlite` and `examples/_legacy/scitex/clew/multi_parent/scitex/clew.db` — two live database files committed into the tree. - `examples/_legacy/notebooks/19_scitex_db.ipynb` — a tutorial for the retired engine end to end (raw client connections, `sqlite_master` introspection). Nothing survives removing the engine from it, so the notebook goes and the master index's two links to it go with it. Rewritten to name PostgreSQL, which is what we actually run: - README's `scitex.db` section, `docs/05_ADDITIONAL_MODULES.md`, and the clew provenance prose in `docs/sphinx/core_concepts.rst` / `docs/sphinx/modules/io.rst`. - `examples/_legacy/scitex/io/schematic_io_concept.py` and its recorded `_out/` YAML — the schematic's store box. Also: - `tests/integration/test_integration.py` no longer asserts the engine's wrapper class is exported; it still asserts `PostgreSQL` and `check_health`. - `tests/integration/test_cross_package_imports.py` drops `scitex_io._load_modules._sqlite3` — that module was deleted in scitex-io 0.3.0, so the entry has silently skipped ever since. - The engine's name leaves `.gitignore` (both copies), `pyproject.toml`'s clew comment, the stdlib table in `scripts/maintenance/_pypi_packages.py`, the CrossRef env example, and the legacy io-module guideline's format table. - `examples/_legacy/notebooks/27_scitex_scholar.ipynb` no longer opens a raw client against the third-party impact-factor database; Scholar's own `enrich_by_default=True` already does that enrichment. No guard test asserting the name's absence is added, deliberately.
Running the suite after deleting the two committed database files re-created `.scitex/clew/runtime/clew.db` (84 KB, magic bytes `SQLite format 3`). The writer is the `scitex-clew` package pinned in `pyproject.toml`, so this repo cannot stop the write — but it can stop the file from being re-committed, which is how it got in. Nothing was ignoring that path: the previous file was TRACKED, so it never showed up as untracked noise and nobody added a rule.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
We do not use the retired embedded engine. Runtime state lives in PostgreSQL on
55432. Its name nevertheless survived in 20 tracked files here — including two
live database files committed into the tree.
Standing ruling applied: nothing outside
docs/adr/may keep the name, andno guard test asserting its absence — so none is added.
Deleted outright
.scitex/clew/runtime/db.sqliteandexamples/_legacy/scitex/clew/multi_parent/scitex/clew.db— two real databasefiles committed into the repository.
examples/_legacy/notebooks/19_scitex_db.ipynb— a tutorial for the retiredengine end to end: raw client connections,
SELECT ... FROM sqlite_masterintrospection, "SQLite for local work" as the closing advice. Nothing survives
removing the engine from it, so the notebook goes, and the master index's two
links to it go with it.
Rewritten to name PostgreSQL
scitex.dbsection (summary line, the worked example, the closingparagraph).
docs/05_ADDITIONAL_MODULES.mdmodule table row.docs/sphinx/core_concepts.rstanddocs/sphinx/modules/io.rst.examples/_legacy/scitex/io/schematic_io_concept.pyand its recorded_out/YAML — the schematic's store box, kept consistent between source and output.
Tests
tests/integration/test_integration.pyno longer asserts the engine's wrapperclass is exported from
stx.db; it still assertsPostgreSQLandcheck_health.tests/integration/test_cross_package_imports.pydropsscitex_io._load_modules._sqlite3. That module was deleted in scitex-io0.3.0, so the entry has silently skipped ever since — it was testing
nothing.
Also
.gitignore(both copies of the Django block), the clewcomment in
pyproject.toml, the stdlib table inscripts/maintenance/_pypi_packages.py(behaviour-neutral: the name is not inKNOWN_PACKAGESeither, soget_package_namestill returnsNone), theCrossRef env example, and the legacy io-module guideline's format table.
examples/_legacy/notebooks/27_scitex_scholar.ipynbno longer opens a rawclient against the third-party impact-factor database. Scholar's own
enrich_by_default=Truealready performs that enrichment — the removed blockswere labelled as fallbacks for when it did not.
A finding this PR cannot fix
Running the suite after deleting the two committed database files re-created
.scitex/clew/runtime/clew.db— 84 KB, first sixteen bytesSQLite format 3.The writer is
scitex-clew==0.17.0, an external pin; this repo cannot stop thewrite. What it can stop is the file being committed again, so the second commit
adds an ignore rule for that path. Nothing was ignoring it before — the previous
file was tracked, so it never appeared as untracked noise and no rule was ever
added. The engine still runs at runtime via
scitex-clew; that belongs in thescitex-clewleaf, not here.Verification
Positive control first — the same search, same root, for a string known to be
present, so the zero below cannot be a broken search:
Then the actual query:
Zero matches across the whole tree.
docs/adr/holds none in this repo either,so no exemption is being leaned on.
561 passed, 101 skipped, 44 xfailed, 17 xpassedlocally, 0 failed.CI may still go red on the py3.13 leg for a reproducible segfault
(
Fatal Python error: Segmentation fault, no JUnit report) that predates thisbranch and is tracked separately — it is not caused by anything here.
Overlap
#362, #364, #365, #366 and #368 are open against the same subject. This branch
is cut fresh from
origin/developand takes the count to a measured zero; if itlands, those should close.