Skip to content

Fix(SCIMMY.Messages.PatchOp): empty array error on custom extension #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sp1r1t wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix(SCIMMY.Messages.PatchOp): empty array error on custom extension #106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db004f5
Fix(SCIMMY.Messages.PatchOp): empty array error on custom extension
Apr 13, 2026
c2b765d
FIx(SCIMMY.Types.Filter) safeguard array access
Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lib/messages/patchop.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -380,7 +380,7 @@ export class PatchOp {
// Filter out any values that exist in removals list
target[property] = (target[property] ?? []).filter(v => !removals.includes(v));
// Unset the property if it's now empty
if (target[property].length === 0) target[property] = undefined;
if ((target[property] ?? []).length === 0) target[property] = undefined;
}
} catch (ex) {
if (ex instanceof Types.Error) {
Expand Down
2 changes: 1 addition & 1 deletion src/lib/types/filter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,7 @@ export class Filter extends Array {
*/
match(values) {
// Match against any of the filters in the set
return values.filter(value =>
return values?.filter(value =>
this.some(f => Object.entries(f).every(([attr, expressions]) => {
const [,actual] = Object.entries(value).find(([key]) => key.toLowerCase() === attr.toLowerCase()) ?? [];
const isActualDate = (actual instanceof Date || (new Date(actual).toString() !== "Invalid Date" && String(actual).match(isoDate)));
Expand Down