Fix(SCIMMY.Messages.PatchOp): empty array error on custom extension#106
Open
sp1r1t wants to merge 2 commits into
Open
Fix(SCIMMY.Messages.PatchOp): empty array error on custom extension#106sp1r1t wants to merge 2 commits into
sp1r1t wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running a "Remove" patch operation on an array in a custom extension I get the error:
Cannot read properties of undefined (reading 'length')The error arises in
patchop.json line 383:patchop.js:380-383
The issue arises because
target[property]is a schema instance, which returnsundefinedwhen it has no values.schema.js:204
This PR fixes the issue by safeguarding the
.lengthcall by coalescing to an empty array iftarget[property]is nullish.