Skip to content

fix(instance): fetch local_storage_max_size from Instance API #5496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
remyleone merged 2 commits into from
Apr 21, 2026
Merged

fix(instance): fetch local_storage_max_size from Instance API #5496

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dcbe7c4
fetch local_storage_max_size from Instance API
Mia-Cross Apr 20, 2026
db3ef50
Merge branch 'main' into instance_pcu_fix_local_storage_max_size
Mia-Cross Apr 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion internal/namespaces/instance/v1/custom_server_type.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ func serverTypeListBuilder(c *core.Command) *core.Command {
return nil, err
}

// Get server types from Instance API (still needed for the number of file systems)
// Get server types from Instance API (still needed for the number of file systems and local storage details)
computeServerTypes, err := instanceAPI.ListServersTypes(request, scw.WithAllPages())
if err != nil {
return nil, err
Expand Down Expand Up @@ -149,6 +149,7 @@ func serverTypeListBuilder(c *core.Command) *core.Command {

if computeServerType, ok := computeServerTypes.Servers[name]; ok {
serverType.MaxFileSystems = new(computeServerType.Capabilities.MaxFileSystems)
serverType.LocalVolumeMaxSize = computeServerType.VolumesConstraint.MaxSize
}

if pcuServerType.Properties.Hardware != nil {
Expand Down
74 changes: 37 additions & 37 deletions internal/namespaces/instance/v1/testdata/test-server-type-list-on-fr-par1.cassette.yaml
View file
Open in desktop

Large diffs are not rendered by default.

30 changes: 15 additions & 15 deletions internal/namespaces/instance/v1/testdata/test-server-type-list-on-fr-par1.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ STANDARD2-A64C-256G € 2.0142 Block 64 0 256 GiB arm6
PRO2-XXS € 0.055 Block 2 0 8.0 GiB x64 350 MB available 0
PRO2-XS € 0.11 Block 4 0 16 GiB x64 700 MB available 0
PRO2-S € 0.219 Block 8 0 32 GiB x64 1.5 GB available 0
PRO2-M € 0.438 Block 16 0 64 GiB x64 3.0 GB low stock 0
PRO2-M € 0.438 Block 16 0 64 GiB x64 3.0 GB available 0
PRO2-L € 0.877 Block 32 0 128 GiB x64 6.0 GB low stock 0
GP1-XS € 0.091 Local, Block 4 0 16 GiB x64 500 MB available 0
GP1-S € 0.187 Local, Block 8 0 32 GiB x64 800 MB available 0
Expand Down Expand Up @@ -95,7 +95,7 @@ POP2-HN-10 € 0.7264 Block 4 0 8.0 GiB x64
L4-8-24G € 0.10 Block 64 8 384 GiB x64 20 GB out of stock 16
L4-4-24G € 0.05 Block 32 4 192 GiB x64 10 GB out of stock 8
L4-2-24G € 0.025 Block 16 2 96 GiB x64 5.0 GB low stock 4
L4-1-24G € 0.0125 Block 8 1 48 GiB x64 2.5 GB low stock 2
L4-1-24G € 0.0125 Block 8 1 48 GiB x64 2.5 GB available 2
RENDER-S € 1.221 Local, Block 10 1 42 GiB x64 2.0 GB available 0
🟩🟩🟩 JSON STDOUT 🟩🟩🟩
[
Expand Down Expand Up @@ -878,7 +878,7 @@ RENDER-S € 1.221 Local, Block 10 1 42 GiB x64
"ram": 68719476736,
"arch": "x64",
"bandwidth": 3000000000,
"availability": "scarce",
"availability": "available",
"max_file_systems": 0
},
{
Expand All @@ -905,7 +905,7 @@ RENDER-S € 1.221 Local, Block 10 1 42 GiB x64
"units": 0,
"nanos": 91000000
},
"local_volume_max_size": 0,
"local_volume_max_size": 150000000000,
"supported_storage": "Local, Block",
"cpu": 4,
"gpu": 0,
Expand All @@ -922,7 +922,7 @@ RENDER-S € 1.221 Local, Block 10 1 42 GiB x64
"units": 0,
"nanos": 187000000
},
"local_volume_max_size": 0,
"local_volume_max_size": 300000000000,
"supported_storage": "Local, Block",
"cpu": 8,
"gpu": 0,
Expand All @@ -939,7 +939,7 @@ RENDER-S € 1.221 Local, Block 10 1 42 GiB x64
"units": 0,
"nanos": 376000000
},
"local_volume_max_size": 0,
"local_volume_max_size": 600000000000,
"supported_storage": "Local, Block",
"cpu": 16,
"gpu": 0,
Expand All @@ -956,7 +956,7 @@ RENDER-S € 1.221 Local, Block 10 1 42 GiB x64
"units": 0,
"nanos": 759000000
},
"local_volume_max_size": 0,
"local_volume_max_size": 600000000000,
"supported_storage": "Local, Block",
"cpu": 32,
"gpu": 0,
Expand All @@ -973,7 +973,7 @@ RENDER-S € 1.221 Local, Block 10 1 42 GiB x64
"units": 1,
"nanos": 641000000
},
"local_volume_max_size": 0,
"local_volume_max_size": 600000000000,
"supported_storage": "Local, Block",
"cpu": 48,
"gpu": 0,
Expand Down Expand Up @@ -1041,7 +1041,7 @@ RENDER-S € 1.221 Local, Block 10 1 42 GiB x64
"units": 0,
"nanos": 150000
},
"local_volume_max_size": 0,
"local_volume_max_size": 10000000000,
"supported_storage": "Local, Block",
"cpu": 1,
"gpu": 0,
Expand All @@ -1058,7 +1058,7 @@ RENDER-S € 1.221 Local, Block 10 1 42 GiB x64
"units": 0,
"nanos": 8800000
},
"local_volume_max_size": 0,
"local_volume_max_size": 20000000000,
"supported_storage": "Local, Block",
"cpu": 2,
"gpu": 0,
Expand All @@ -1075,7 +1075,7 @@ RENDER-S € 1.221 Local, Block 10 1 42 GiB x64
"units": 0,
"nanos": 19800000
},
"local_volume_max_size": 0,
"local_volume_max_size": 40000000000,
"supported_storage": "Local, Block",
"cpu": 3,
"gpu": 0,
Expand All @@ -1092,7 +1092,7 @@ RENDER-S € 1.221 Local, Block 10 1 42 GiB x64
"units": 0,
"nanos": 42000000
},
"local_volume_max_size": 0,
"local_volume_max_size": 80000000000,
"supported_storage": "Local, Block",
"cpu": 4,
"gpu": 0,
Expand All @@ -1109,7 +1109,7 @@ RENDER-S € 1.221 Local, Block 10 1 42 GiB x64
"units": 0,
"nanos": 63799999
},
"local_volume_max_size": 0,
"local_volume_max_size": 120000000000,
"supported_storage": "Local, Block",
"cpu": 4,
"gpu": 0,
Expand Down Expand Up @@ -1711,7 +1711,7 @@ RENDER-S € 1.221 Local, Block 10 1 42 GiB x64
"ram": 51539607552,
"arch": "x64",
"bandwidth": 2500000000,
"availability": "scarce",
"availability": "available",
"max_file_systems": 2
},
{
Expand All @@ -1721,7 +1721,7 @@ RENDER-S € 1.221 Local, Block 10 1 42 GiB x64
"units": 1,
"nanos": 221000000
},
"local_volume_max_size": 0,
"local_volume_max_size": 400000000000,
"supported_storage": "Local, Block",
"cpu": 10,
"gpu": 1,
Expand Down
30 changes: 15 additions & 15 deletions internal/namespaces/instance/v1/testdata/test-server-type-list-on-it-mil1.cassette.yaml
View file
Open in desktop

Large diffs are not rendered by default.

46 changes: 23 additions & 23 deletions internal/namespaces/instance/v1/testdata/test-server-type-list-on-nl-ams2.cassette.yaml
View file
Open in desktop

Large diffs are not rendered by default.

18 changes: 9 additions & 9 deletions internal/namespaces/instance/v1/testdata/test-server-type-list-on-nl-ams2.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -539,7 +539,7 @@ POP2-HN-10 € 0.7264 Block 4 0 8.0 GiB x64
"units": 0,
"nanos": 91000000
},
"local_volume_max_size": 0,
"local_volume_max_size": 150000000000,
"supported_storage": "Local, Block",
"cpu": 4,
"gpu": 0,
Expand All @@ -556,7 +556,7 @@ POP2-HN-10 € 0.7264 Block 4 0 8.0 GiB x64
"units": 0,
"nanos": 187000000
},
"local_volume_max_size": 0,
"local_volume_max_size": 300000000000,
"supported_storage": "Local, Block",
"cpu": 8,
"gpu": 0,
Expand All @@ -573,7 +573,7 @@ POP2-HN-10 € 0.7264 Block 4 0 8.0 GiB x64
"units": 0,
"nanos": 376000000
},
"local_volume_max_size": 0,
"local_volume_max_size": 600000000000,
"supported_storage": "Local, Block",
"cpu": 16,
"gpu": 0,
Expand All @@ -590,7 +590,7 @@ POP2-HN-10 € 0.7264 Block 4 0 8.0 GiB x64
"units": 0,
"nanos": 759000000
},
"local_volume_max_size": 0,
"local_volume_max_size": 600000000000,
"supported_storage": "Local, Block",
"cpu": 32,
"gpu": 0,
Expand All @@ -607,7 +607,7 @@ POP2-HN-10 € 0.7264 Block 4 0 8.0 GiB x64
"units": 1,
"nanos": 641000000
},
"local_volume_max_size": 0,
"local_volume_max_size": 600000000000,
"supported_storage": "Local, Block",
"cpu": 48,
"gpu": 0,
Expand Down Expand Up @@ -675,7 +675,7 @@ POP2-HN-10 € 0.7264 Block 4 0 8.0 GiB x64
"units": 0,
"nanos": 8800000
},
"local_volume_max_size": 0,
"local_volume_max_size": 20000000000,
"supported_storage": "Local, Block",
"cpu": 2,
"gpu": 0,
Expand All @@ -692,7 +692,7 @@ POP2-HN-10 € 0.7264 Block 4 0 8.0 GiB x64
"units": 0,
"nanos": 19800000
},
"local_volume_max_size": 0,
"local_volume_max_size": 40000000000,
"supported_storage": "Local, Block",
"cpu": 3,
"gpu": 0,
Expand All @@ -709,7 +709,7 @@ POP2-HN-10 € 0.7264 Block 4 0 8.0 GiB x64
"units": 0,
"nanos": 42000000
},
"local_volume_max_size": 0,
"local_volume_max_size": 80000000000,
"supported_storage": "Local, Block",
"cpu": 4,
"gpu": 0,
Expand All @@ -726,7 +726,7 @@ POP2-HN-10 € 0.7264 Block 4 0 8.0 GiB x64
"units": 0,
"nanos": 63799999
},
"local_volume_max_size": 0,
"local_volume_max_size": 120000000000,
"supported_storage": "Local, Block",
"cpu": 4,
"gpu": 0,
Expand Down
30 changes: 15 additions & 15 deletions internal/namespaces/instance/v1/testdata/test-server-type-list-on-pl-waw1.cassette.yaml
View file
Open in desktop

Large diffs are not rendered by default.

18 changes: 9 additions & 9 deletions internal/namespaces/instance/v1/testdata/test-server-type-list-on-pl-waw1.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,7 @@ POP2-HN-10 € 0.7264 Block 4 0 8.0 GiB x64 1
"units": 0,
"nanos": 91000000
},
"local_volume_max_size": 0,
"local_volume_max_size": 150000000000,
"supported_storage": "Local, Block",
"cpu": 4,
"gpu": 0,
Expand All @@ -265,7 +265,7 @@ POP2-HN-10 € 0.7264 Block 4 0 8.0 GiB x64 1
"units": 0,
"nanos": 187000000
},
"local_volume_max_size": 0,
"local_volume_max_size": 300000000000,
"supported_storage": "Local, Block",
"cpu": 8,
"gpu": 0,
Expand All @@ -282,7 +282,7 @@ POP2-HN-10 € 0.7264 Block 4 0 8.0 GiB x64 1
"units": 0,
"nanos": 376000000
},
"local_volume_max_size": 0,
"local_volume_max_size": 600000000000,
"supported_storage": "Local, Block",
"cpu": 16,
"gpu": 0,
Expand All @@ -299,7 +299,7 @@ POP2-HN-10 € 0.7264 Block 4 0 8.0 GiB x64 1
"units": 0,
"nanos": 759000000
},
"local_volume_max_size": 0,
"local_volume_max_size": 600000000000,
"supported_storage": "Local, Block",
"cpu": 32,
"gpu": 0,
Expand All @@ -316,7 +316,7 @@ POP2-HN-10 € 0.7264 Block 4 0 8.0 GiB x64 1
"units": 1,
"nanos": 641000000
},
"local_volume_max_size": 0,
"local_volume_max_size": 600000000000,
"supported_storage": "Local, Block",
"cpu": 48,
"gpu": 0,
Expand Down Expand Up @@ -384,7 +384,7 @@ POP2-HN-10 € 0.7264 Block 4 0 8.0 GiB x64 1
"units": 0,
"nanos": 8800000
},
"local_volume_max_size": 0,
"local_volume_max_size": 20000000000,
"supported_storage": "Local, Block",
"cpu": 2,
"gpu": 0,
Expand All @@ -401,7 +401,7 @@ POP2-HN-10 € 0.7264 Block 4 0 8.0 GiB x64 1
"units": 0,
"nanos": 19800000
},
"local_volume_max_size": 0,
"local_volume_max_size": 40000000000,
"supported_storage": "Local, Block",
"cpu": 3,
"gpu": 0,
Expand All @@ -418,7 +418,7 @@ POP2-HN-10 € 0.7264 Block 4 0 8.0 GiB x64 1
"units": 0,
"nanos": 42000000
},
"local_volume_max_size": 0,
"local_volume_max_size": 80000000000,
"supported_storage": "Local, Block",
"cpu": 4,
"gpu": 0,
Expand All @@ -435,7 +435,7 @@ POP2-HN-10 € 0.7264 Block 4 0 8.0 GiB x64 1
"units": 0,
"nanos": 63799999
},
"local_volume_max_size": 0,
"local_volume_max_size": 120000000000,
"supported_storage": "Local, Block",
"cpu": 4,
"gpu": 0,
Expand Down
Loading