Skip to content

fix(instance): fetch local_storage_max_size from Instance API#5496

Merged
remyleone merged 2 commits intoscaleway:mainfrom
Mia-Cross:instance_pcu_fix_local_storage_max_size
Apr 21, 2026
Merged

fix(instance): fetch local_storage_max_size from Instance API#5496
remyleone merged 2 commits intoscaleway:mainfrom
Mia-Cross:instance_pcu_fix_local_storage_max_size

Conversation

@Mia-Cross
Copy link
Copy Markdown
Contributor

@Mia-Cross Mia-Cross commented Apr 20, 2026

#5379 was supposed to keep the field local_storage_max_size for the json output but the field was not present in the PCU so it got left out.

This PR restores the previous behavior and fetches the information from the Instance API, along with the max number of file systems, which are now the 2 fields that are still retrieved from this API and not the PCU.

@Mia-Cross Mia-Cross self-assigned this Apr 20, 2026
@Mia-Cross Mia-Cross added bug instance Instance issues, bugs and feature requests priority:highest Bugs filled by customers, security issues labels Apr 20, 2026
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.36%. Comparing base (7881ee1) to head (db3ef50).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5496   +/-   ##
=======================================
  Coverage   50.36%   50.36%           
=======================================
  Files         325      325           
  Lines       77384    77385    +1     
=======================================
+ Hits        38973    38974    +1     
  Misses      36933    36933           
  Partials     1478     1478           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Mia-Cross Mia-Cross marked this pull request as ready for review April 20, 2026 15:52
@Mia-Cross Mia-Cross requested a review from a team as a code owner April 20, 2026 15:52
@remyleone remyleone added this pull request to the merge queue Apr 21, 2026
Merged via the queue into scaleway:main with commit 0142aaa Apr 21, 2026
121 checks passed
@Mia-Cross Mia-Cross deleted the instance_pcu_fix_local_storage_max_size branch April 21, 2026 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug instance Instance issues, bugs and feature requests priority:highest Bugs filled by customers, security issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants