fix(instance): fetch local_storage_max_size from Instance API#5496
Merged
remyleone merged 2 commits intoscaleway:mainfrom Apr 21, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5496 +/- ##
=======================================
Coverage 50.36% 50.36%
=======================================
Files 325 325
Lines 77384 77385 +1
=======================================
+ Hits 38973 38974 +1
Misses 36933 36933
Partials 1478 1478 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
remyleone
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#5379 was supposed to keep the field
local_storage_max_sizefor the json output but the field was not present in the PCU so it got left out.This PR restores the previous behavior and fetches the information from the Instance API, along with the max number of file systems, which are now the 2 fields that are still retrieved from this API and not the PCU.