Skip to content

LDAP users: scrub legacy password hashes on login (#103) #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alorbach merged 1 commit into from
May 4, 2026
Merged

LDAP users: scrub legacy password hashes on login (#103) #119

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/include/functions_users.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,7 +386,7 @@ function CheckLDAPUserLogin( $username, $password )
}

// for the moment when a user logs in from LDAP, create it in the DB.
// then the prefs and group management is done in the DB and we don't rewrite the whole Loganalyzer code…
// then the prefs and group management is done in the DB and we don't rewrite the whole Loganalyzer code.

/* Don't store LDAP passwords in database */
$md5pass = '';
Expand All @@ -397,7 +397,7 @@ function CheckLDAPUserLogin( $username, $password )
$myrow = DB_GetSingleRow($result, true);
if (!isset($myrow['is_admin']) )
{
// Create User | use password to create MD5 Hash, so technically the user could login without LDAP as well
// Create User: password column left empty; authentication is via LDAP only while UserDBAuthMode is LDAP.
$sqlcmd = "INSERT INTO `" . DB_USERS . "` (username, password, is_admin, is_readonly) VALUES ('" . $username . "', '" . $md5pass . "', 0, 1)";

$result = DB_Query($sqlcmd);
Expand All @@ -406,6 +406,13 @@ function CheckLDAPUserLogin( $username, $password )
$myrow['last_login'] = 0;
$myrow['is_readonly'] = 1;
}
else if ( isset($myrow['password']) && strlen($myrow['password']) > 0 )
{
// Scrub legacy MD5 hashes from before LDAP passwords were stopped being stored.
$result = DB_Query("UPDATE `" . DB_USERS . "` SET password = '' WHERE ID = " . intval($myrow['ID']));
DB_FreeQuery($result);
$myrow['password'] = '';
}

// Construct Row and return
$myrowfinal['username'] = $username;
Expand Down
Loading