LDAP users: scrub legacy password hashes on login (#103) - #119
Merged
Conversation
alorbach
commented
May 4, 2026
alorbach
commented
Member
- Replace misleading INSERT comment (password is not stored for LDAP).
- On successful LDAP login, clear non-empty password column for existing rows so pre-fix MD5 values are removed automatically.
- Fix corrupted UTF-8 at end of adjacent comment line.
- Replace misleading INSERT comment (password is not stored for LDAP). - On successful LDAP login, clear non-empty password column for existing rows so pre-fix MD5 values are removed automatically. - Fix corrupted UTF-8 at end of adjacent comment line. Co-authored-by: Cursor <cursoragent@cursor.com>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates src/include/functions_users.php to refine LDAP user management. It fixes a character encoding issue in a comment and updates documentation regarding password storage for LDAP accounts. Additionally, it adds logic to automatically scrub legacy MD5 password hashes from the database when an LDAP user authenticates, ensuring that authentication is handled exclusively via LDAP. I have no feedback to provide.
This was referenced May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.